Re: [PATCH 9/9] tty: serial_core: add tty NULL check in uart_port_startup

From	One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH 9/9] tty: serial_core: add tty NULL check in uart_port_startup
Date	2016-09-11 23:30 +0200
Message-ID	<sgku5-2SE-5@gated-at.bofh.it> (permalink)
References	<sfCCJ-mH-3@gated-at.bofh.it> <sfCCJ-mH-15@gated-at.bofh.it>
Organization	Intel Corporation

Show all headers | View raw

On Fri,  9 Sep 2016 17:37:10 -0500
Rob Herring <robh@kernel.org> wrote:

> If we don't have a tty when calling uart_port_startup, skip the baudrate
> and modem control setup which depend on tty->termios struct. Either
> tty_port clients will configure the line in a separate call or we'll
> move termios into the tty_port.

I don't think getting rid of the tty object makes any sense whatsoever
just create a kernel one.

Either way the giant churny patch and this hack should be deferred in
favour of moving the termios structure into the tty port (and the locks
for it) and doing the right job once.

The termios does I agree belong in the tty_port so irrespective of final
direction fixing that is a right move.

Alan

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 9/9] tty: serial_core: add tty NULL check in uart_port_startup Rob Herring <robh@kernel.org> - 2016-09-10 00:40 +0200
  Re: [PATCH 9/9] tty: serial_core: add tty NULL check in  uart_port_startup One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> - 2016-09-11 23:30 +0200

csiph-web