Re: [PATCH v3] net: ip, diag -- Add diag interface for raw sockets

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] net: ip, diag -- Add diag interface for raw sockets
Date	2016-09-13 18:00 +0200
Message-ID	<sgYhP-3RY-11@gated-at.bofh.it> (permalink)
References	<sfYDf-5Qh-5@gated-at.bofh.it> <sfYWC-60u-7@gated-at.bofh.it> <sgisi-1Eo-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Cyrill Gorcunov <gorcunov@gmail.com>
Date: Sun, 11 Sep 2016 22:17:15 +0300

> On Sat, Sep 10, 2016 at 04:28:40PM -0600, David Ahern wrote:
>> On 9/10/16 4:05 PM, Cyrill Gorcunov wrote:
>> > On Sat, Sep 10, 2016 at 10:31:35AM -0600, David Ahern wrote:
>> >>
>> >> Would you mind adding the destroy capability as well? The udp version
>> >> should be close to what is needed for raw sockets. See udp_diag_destroy
>> >> and udp_abort.
>> > 
>> > Should be something like below. Didn't tested it yet so for review only.
>> > Will do testing at Monday.
>> 
>> doesn't compile:
>> - raw_abort needs to be in a header for ipv6, and
>> - inet_sk_diag_fill args have changed due to a recent commit
> 
> Thanks for review, David. I updated against net-next.

Please do not post new versions of patches as replies to existing
discussions.

Instead, make fresh patch postings to the list.

Thanks.

Thread

[PATCH] net: ip, diag -- Add diag interface for raw sockets Cyrill Gorcunov <gorcunov@gmail.com> - 2016-09-09 20:30 +0200
  Re: [PATCH] net: ip, diag -- Add diag interface for raw sockets Eric Dumazet <eric.dumazet@gmail.com> - 2016-09-09 22:00 +0200
    Re: [PATCH] net: ip, diag -- Add diag interface for raw sockets Cyrill Gorcunov <gorcunov@gmail.com> - 2016-09-09 22:20 +0200
  Re: [PATCH] net: ip, diag -- Add diag interface for raw sockets David Ahern <dsa@cumulusnetworks.com> - 2016-09-10 18:40 +0200
    Re: [PATCH] net: ip, diag -- Add diag interface for raw sockets Cyrill Gorcunov <gorcunov@gmail.com> - 2016-09-10 21:40 +0200
    [PATCH v2] net: ip, diag -- Add diag interface for raw sockets Cyrill Gorcunov <gorcunov@gmail.com> - 2016-09-11 00:10 +0200
      Re: [PATCH v2] net: ip, diag -- Add diag interface for raw sockets David Ahern <dsa@cumulusnetworks.com> - 2016-09-11 00:30 +0200
        [PATCH v3] net: ip, diag -- Add diag interface for raw sockets Cyrill Gorcunov <gorcunov@gmail.com> - 2016-09-11 21:20 +0200
          Re: [PATCH v3] net: ip, diag -- Add diag interface for raw sockets David Miller <davem@davemloft.net> - 2016-09-13 18:00 +0200
            Re: [PATCH v3] net: ip, diag -- Add diag interface for raw sockets Cyrill Gorcunov <gorcunov@gmail.com> - 2016-09-13 18:40 +0200

csiph-web