Re: [PATCH v2] mm, proc: Fix region lost in /proc/self/smaps

From	Dave Hansen <dave.hansen@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] mm, proc: Fix region lost in /proc/self/smaps
Date	2016-09-13 18:30 +0200
Message-ID	<sgYKS-4ky-29@gated-at.bofh.it> (permalink)
References	<sgq6t-6lB-1@gated-at.bofh.it> <sgz06-3qM-9@gated-at.bofh.it> <sgB1U-4WE-21@gated-at.bofh.it> <sgEVP-7xR-13@gated-at.bofh.it> <sgXvs-3zH-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 09/13/2016 07:59 AM, Oleg Nesterov wrote:
> On 09/12, Michal Hocko wrote:
>> > Considering how this all can be tricky and how partial reads can be
>> > confusing and even misleading I am really wondering whether we
>> > should simply document that only full reads will provide a sensible
>> > results.
> I agree. I don't even understand why this was considered as a bug.
> Obviously, m_stop() which drops mmap_sep should not be called, or
> all the threads should be stopped, if you want to trust the result.

There was a mapping at a given address.  That mapping did not change, it
was not split, its attributes did not change.  But, it didn't show up
when reading smaps.  Folks _actually_ noticed this in a test suite
looking for that address range in smaps.

IOW, we had goofy kernel behavior, and it broke a reasonable test
program.  The test program just used fgets() to read into a fixed-length
buffer, which is a completely normal thing to do.

To get "sensible results", doesn't userspace have to somehow know in
advance how many bytes of data a given VMA will generate in smaps output?

Thread

[PATCH v2] mm, proc: Fix region lost in /proc/self/smaps Xiao Guangrong <guangrong.xiao@linux.intel.com> - 2016-09-12 05:30 +0200
  Re: [PATCH v2] mm, proc: Fix region lost in /proc/self/smaps Michal Hocko <mhocko@kernel.org> - 2016-09-12 15:00 +0200
    Re: [PATCH v2] mm, proc: Fix region lost in /proc/self/smaps Dave Hansen <dave.hansen@intel.com> - 2016-09-12 17:10 +0200
      Re: [PATCH v2] mm, proc: Fix region lost in /proc/self/smaps Michal Hocko <mhocko@kernel.org> - 2016-09-12 21:20 +0200
        Re: [PATCH v2] mm, proc: Fix region lost in /proc/self/smaps Xiao Guangrong <guangrong.xiao@linux.intel.com> - 2016-09-13 05:10 +0200
        Re: [PATCH v2] mm, proc: Fix region lost in /proc/self/smaps Oleg Nesterov <oleg@redhat.com> - 2016-09-13 17:10 +0200
          Re: [PATCH v2] mm, proc: Fix region lost in /proc/self/smaps Dave Hansen <dave.hansen@intel.com> - 2016-09-13 18:30 +0200
            Re: [PATCH v2] mm, proc: Fix region lost in /proc/self/smaps Oleg Nesterov <oleg@redhat.com> - 2016-09-14 17:40 +0200
              Re: [PATCH v2] mm, proc: Fix region lost in /proc/self/smaps Xiao Guangrong <guangrong.xiao@linux.intel.com> - 2016-09-19 09:30 +0200

csiph-web