[PATCH 2/4] mfd: lpc_ich: Do not create iTCO watchdog when WDAT table exists

From	Mika Westerberg <mika.westerberg@linux.intel.com>
Newsgroups	linux.kernel
Subject	[PATCH 2/4] mfd: lpc_ich: Do not create iTCO watchdog when WDAT table exists
Date	2016-09-13 17:30 +0200
Message-ID	<sgXOO-3H6-19@gated-at.bofh.it> (permalink)
References	<sgXOO-3H6-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

ACPI WDAT table is the preferred way to use hardware watchdog over the
native iTCO_wdt. Windows only uses this table for its hardware watchdog
implementation so we should be relatively safe to trust it has been
validated by OEMs

Prevent iTCO watchdog creation if we detect that there is ACPI WDAT table.

Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
 drivers/mfd/lpc_ich.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/mfd/lpc_ich.c b/drivers/mfd/lpc_ich.c
index bd3aa4578346..c8dee47b45d9 100644
--- a/drivers/mfd/lpc_ich.c
+++ b/drivers/mfd/lpc_ich.c
@@ -984,6 +984,10 @@ static int lpc_ich_init_wdt(struct pci_dev *dev)
 	int ret;
 	struct resource *res;
 
+	/* If we have ACPI based watchdog use that instead */
+	if (acpi_has_watchdog())
+		return -ENODEV;
+
 	/* Setup power management base register */
 	pci_read_config_dword(dev, priv->abase, &base_addr_cfg);
 	base_addr = base_addr_cfg & 0x0000ff80;
-- 
2.9.3

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/4] mfd: lpc_ich: Do not create iTCO watchdog when WDAT table exists Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-09-13 17:30 +0200
  Re: [PATCH 2/4] mfd: lpc_ich: Do not create iTCO watchdog when WDAT  table exists Guenter Roeck <linux@roeck-us.net> - 2016-09-14 22:10 +0200

csiph-web