Re: [PATCH] mfd: lp873x: Remove unused mutex lock from struct lp873x

From	Lee Jones <lee.jones@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mfd: lp873x: Remove unused mutex lock from struct lp873x
Date	2016-09-13 14:50 +0200
Message-ID	<sgVjY-1TH-39@gated-at.bofh.it> (permalink)
References	<sed3I-3i6-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 06 Sep 2016, Axel Lin wrote:

> The mutex is not used, so remove it.
> 
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
>  drivers/mfd/lp873x.c       | 2 --
>  include/linux/mfd/lp873x.h | 1 -
>  2 files changed, 3 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/lp873x.c b/drivers/mfd/lp873x.c
> index 9af064c..873c608 100644
> --- a/drivers/mfd/lp873x.c
> +++ b/drivers/mfd/lp873x.c
> @@ -53,8 +53,6 @@ static int lp873x_probe(struct i2c_client *client,
>  		return ret;
>  	}
>  
> -	mutex_init(&lp873->lock);
> -
>  	ret = regmap_read(lp873->regmap, LP873X_REG_OTP_REV, &otpid);
>  	if (ret) {
>  		dev_err(lp873->dev, "Failed to read OTP ID\n");
> diff --git a/include/linux/mfd/lp873x.h b/include/linux/mfd/lp873x.h
> index 83b1bd7..edbec83 100644
> --- a/include/linux/mfd/lp873x.h
> +++ b/include/linux/mfd/lp873x.h
> @@ -263,7 +263,6 @@ enum lp873x_regulator_id {
>  struct lp873x {
>  	struct device *dev;
>  	u8 rev;
> -	struct mutex lock;	/* lock guarding the data structure */
>  	struct regmap *regmap;
>  };
>  #endif /* __LINUX_MFD_LP873X_H */

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] mfd: lp873x: Remove unused mutex lock from struct lp873x Lee Jones <lee.jones@linaro.org> - 2016-09-13 14:50 +0200

csiph-web