Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1482454

Re: [PATCH v3 01/15] x86/dumpstack: Optimize save_stack_trace

Show all headers | View raw

On Tue, Sep 13, 2016 at 06:45:00PM +0900, Byungchul Park wrote:
> Currently, x86 implementation of save_stack_trace() is walking all stack
> region word by word regardless of what the trace->max_entries is.
> However, it's unnecessary to walk after already fulfilling caller's
> requirement, say, if trace->nr_entries >= trace->max_entries is true.
> 
> I measured its overhead and printed its difference of sched_clock() with
> my QEMU x86 machine. The latency was improved over 70% when
> trace->max_entries = 5.

This code will (probably) be obsoleted soon with my new unwinder.

Also, my previous comment was ignored:

  Instead of adding a new callback, why not just check the ops->address()
  return value?  It already returns an error if the array is full. 
   
  I think that would be cleaner and would help prevent more callback
  sprawl.

-- 
Josh

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 01/15] x86/dumpstack: Optimize save_stack_trace Byungchul Park <byungchul.park@lge.com> - 2016-09-13 12:00 +0200
  Re: [PATCH v3 01/15] x86/dumpstack: Optimize save_stack_trace Josh Poimboeuf <jpoimboe@redhat.com> - 2016-09-13 15:20 +0200
    Re: [PATCH v3 01/15] x86/dumpstack: Optimize save_stack_trace Byungchul Park <max.byungchul.park@gmail.com> - 2016-09-13 17:00 +0200

csiph-web