Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1482356

Re: [PATCH] usb: Kconfig: make USB_ULPI_BUS select USB_COMMON

Show all headers | View raw

On Tuesday, September 13, 2016 4:50:05 PM CEST Peter Chen wrote:
> On Tue, Sep 13, 2016 at 09:36:39AM +0200, Arnd Bergmann wrote:
> > On Tuesday, September 13, 2016 3:19:42 PM CEST Peter Chen wrote:
> > > 
> > > I just see below Kconfig entry at the same Kconfig
> > > (drivers/usb/Kconfig), and forget your changes.
> > > 
> > > config USB_LED_TRIG
> > >         bool "USB LED Triggers"
> > >         depends on LEDS_CLASS && USB_COMMON && LEDS_TRIGGERS
> > >         help
> > >           This option adds LED triggers for USB host and/or gadget activity.
> > > 
> > >           Say Y here if you are working on a system with led-class supported
> > >           LEDs and you want to use them as activity indicators for USB host or
> > >           gadget.
> > > 
> > > Just grep it, some Kconfig still uses depends on for USB_COMMON, let me
> > > change it together.
> > > 
> > 
> > I suspect this one above should instead depend on "USB_SUPPORT".
> > 
> 
> No, it is embraced by "if USB_SUPPORT", so we don't need to add it
> additionally.

Right, makes sense.

> Even USB_SUPPORT is chosen, the USB_COMMON may still
> not be chosen, so we need let USB_LET_TRIG select USB_COMMON
> explicitly.

My thought was that all users that could possibly call the
USB_LED_TRIG interfaces already rely on USB_COMMON to
be present.

There is probably no real downside in having the 'select USB_COMMON',
but it shouldn't actually be needed. It would be somewhat unusual
though to enable USB_LED_TRIG and not build the file because
we don't enter the directory, so maybe it's better to have it after
all.

	Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] usb: Kconfig: make USB_ULPI_BUS select USB_COMMON Arnd Bergmann <arnd@arndb.de> - 2016-09-12 17:40 +0200
  Re: [PATCH] usb: Kconfig: make USB_ULPI_BUS select USB_COMMON Peter Chen <hzpeterchen@gmail.com> - 2016-09-13 03:50 +0200
    Re: [PATCH] usb: Kconfig: make USB_ULPI_BUS select USB_COMMON Arnd Bergmann <arnd@arndb.de> - 2016-09-13 09:10 +0200
      Re: [PATCH] usb: Kconfig: make USB_ULPI_BUS select USB_COMMON Peter Chen <hzpeterchen@gmail.com> - 2016-09-13 09:20 +0200
        Re: [PATCH] usb: Kconfig: make USB_ULPI_BUS select USB_COMMON Arnd Bergmann <arnd@arndb.de> - 2016-09-13 09:40 +0200
          Re: [PATCH] usb: Kconfig: make USB_ULPI_BUS select USB_COMMON Peter Chen <hzpeterchen@gmail.com> - 2016-09-13 11:00 +0200
            Re: [PATCH] usb: Kconfig: make USB_ULPI_BUS select USB_COMMON Arnd Bergmann <arnd@arndb.de> - 2016-09-13 12:40 +0200

csiph-web