Re: [PATCH v8 4/9] drm/mediatek: update display module connections

From	CK Hu <ck.hu@mediatek.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v8 4/9] drm/mediatek: update display module connections
Date	2016-09-13 11:50 +0200
Message-ID	<sgSvL-8uI-7@gated-at.bofh.it> (permalink)
References	<sgydH-35W-5@gated-at.bofh.it> <sgydH-35W-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi, YT:

On Mon, 2016-09-12 at 20:01 +0800, YT Shen wrote:
> update connections for OVL, RDMA, BLS, DSI
> 
> Signed-off-by: YT Shen <yt.shen@mediatek.com>
> ---

[snip...]

> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h
> index 53065c7..0850aa4 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h
> @@ -40,6 +40,7 @@ enum mtk_ddp_comp_type {
>  
>  enum mtk_ddp_comp_id {
>  	DDP_COMPONENT_AAL,
> +	DDP_COMPONENT_BLS,

I think this should be moved to an independent patch and title of it
should be "Add BLS component." If you keep it in this patch, title of
this patch should be modified as "Add BLS component and update display
module connections."

Regards,
CK

>  	DDP_COMPONENT_COLOR0,
>  	DDP_COMPONENT_COLOR1,
>  	DDP_COMPONENT_DPI0,

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v8 4/9] drm/mediatek: update display module connections YT Shen <yt.shen@mediatek.com> - 2016-09-12 14:10 +0200
  Re: [PATCH v8 4/9] drm/mediatek: update display module connections CK Hu <ck.hu@mediatek.com> - 2016-09-13 11:50 +0200

csiph-web