Re: [PATCH v7 7/9] drm/mediatek: add dsi transfer function

From	CK Hu <ck.hu@mediatek.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v7 7/9] drm/mediatek: add dsi transfer function
Date	2016-09-13 11:30 +0200
Message-ID	<sgScp-8ns-19@gated-at.bofh.it> (permalink)
References	<scUPw-7ib-13@gated-at.bofh.it> <scUPw-7ib-21@gated-at.bofh.it> <seAWm-2bR-1@gated-at.bofh.it> <sgwvg-1VB-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi, YT:

On Mon, 2016-09-12 at 18:16 +0800, YT Shen wrote:
> Hi CK,
> 
> On Wed, 2016-09-07 at 10:33 +0800, CK Hu wrote:
> > Hi, YT:
> > 
> > On Fri, 2016-09-02 at 19:24 +0800, YT Shen wrote:
> > > From: shaoming chen <shaoming.chen@mediatek.com>
> > > 
> > > add dsi read/write commands for transfer function
> > > 
> > > Signed-off-by: shaoming chen <shaoming.chen@mediatek.com>
> > > ---
> > >  drivers/gpu/drm/mediatek/mtk_dsi.c | 188 +++++++++++++++++++++++++++++++++++++
> > >  1 file changed, 188 insertions(+)
> > > 
> > 
> > [snip...]
> > 
> > >  
> > > +static void mtk_dsi_irq_data_clear(struct mtk_dsi *dsi, u32 irq_bit)
> > > +{
> > > +	dsi->irq_data &= ~irq_bit;
> > > +}
> > > +
> > 
> > [snip...]
> > 
> > > +
> > > +static s32 mtk_dsi_wait_for_irq_done(struct mtk_dsi *dsi, u32 irq_flag,
> > > +				     unsigned int timeout)
> > > +{
> > > +	s32 ret = 0;
> > > +	unsigned long jiffies = msecs_to_jiffies(timeout);
> > > +
> > > +	ret = wait_event_interruptible_timeout(_dsi_irq_wait_queue,
> > > +					       dsi->irq_data & irq_flag,
> > > +					       jiffies);
> > > +	if (ret == 0) {
> > > +		dev_info(dsi->dev, "Wait DSI IRQ(0x%08x) Timeout\n", irq_flag);
> > > +
> > > +		mtk_dsi_enable(dsi);
> > > +		mtk_dsi_reset_engine(dsi);
> > > +	}
> > > +
> > > +	return ret;
> > > +}
> > 
> > I think mtk_dsi_irq_data_clear() and mtk_dsi_wait_for_irq_done() should
> > be moved to the 6th patch [1] of this series because these two functions
> > deal the irq control.
> We will move mtk_dsi_irq_data_clear() to patch "drm/mediatek: add dsi
> interrupt control" and put mtk_dsi_wait_for_irq_done() here, because it
> is used in the transfer function.

mtk_dsi_irq_data_clear() is also only used in transfer function now. I
think both function could be used for other application rather than
transfer function, so these two function are general function for irq
control.

Regards,
CK

> 
> Regards,
> yt.shen
> > 
> > 
> > [1] https://patchwork.kernel.org/patch/9310819/
> > 
> > 
> > Regards,
> > CK
> > 
> 
>

Thread

Re: [PATCH v7 7/9] drm/mediatek: add dsi transfer function YT Shen <yt.shen@mediatek.com> - 2016-09-12 12:20 +0200
  Re: [PATCH v7 7/9] drm/mediatek: add dsi transfer function CK Hu <ck.hu@mediatek.com> - 2016-09-13 11:30 +0200
    Re: [PATCH v7 7/9] drm/mediatek: add dsi transfer function YT Shen <yt.shen@mediatek.com> - 2016-09-14 08:20 +0200
      Re: [PATCH v7 7/9] drm/mediatek: add dsi transfer function CK Hu <ck.hu@mediatek.com> - 2016-09-14 08:40 +0200
        Re: [PATCH v7 7/9] drm/mediatek: add dsi transfer function YT Shen <yt.shen@mediatek.com> - 2016-09-14 09:30 +0200
          Re: [PATCH v7 7/9] drm/mediatek: add dsi transfer function CK Hu <ck.hu@mediatek.com> - 2016-09-14 09:40 +0200

csiph-web