[Question] Calling request_firmware under the spinlocks in file advansys.c

From	Vaishali Thakkar <vaishali.thakkar@oracle.com>
Newsgroups	linux.kernel
Subject	[Question] Calling request_firmware under the spinlocks in file advansys.c
Date	2016-09-13 11:30 +0200
Message-ID	<sgScp-8ns-17@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

In the file drivers/scsi/advansys.c we are calling function AdvISR at 2 instances
[in the function advansys_reset and advansys_interrupt] while holding spinlock.
Function AdvISR eventually calls request_firmware following this sequence of
routines: 

AdvISR -> adv_async_callback -> AdvResetChipAndSB -> AdvInitAsc3550Driver ->
request_firmware

According to the definition of request_firmware it should be called from user
context where sleeping is allowed. And usually sleeping under the spin lock is
not allowed. Is it really necessary to call AdvISR under spinlocks here? Are
we taking care of sleeping related concern of request_firmware or am I
overlooking something here?

Thank you.

-- 
Vaishali

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[Question] Calling request_firmware under the spinlocks in file  advansys.c Vaishali Thakkar <vaishali.thakkar@oracle.com> - 2016-09-13 11:30 +0200

csiph-web