Re: [PATCH v7 8/9] drm/mediatek: update DSI sub driver flow

From	CK Hu <ck.hu@mediatek.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v7 8/9] drm/mediatek: update DSI sub driver flow
Date	2016-09-13 12:00 +0200
Message-ID	<sgSFs-6J-39@gated-at.bofh.it> (permalink)
References	<scUPw-7ib-13@gated-at.bofh.it> <scUPw-7ib-31@gated-at.bofh.it> <seD7Q-3x6-9@gated-at.bofh.it> <sgwvg-1VB-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi, YT:

On Mon, 2016-09-12 at 18:15 +0800, YT Shen wrote:
> Hi CK,
> 
> On Wed, 2016-09-07 at 12:58 +0800, CK Hu wrote:
> > Hi, YT:
> > 
> > On Fri, 2016-09-02 at 19:24 +0800, YT Shen wrote:
> > > This patch update enable/disable flow of DSI module and MIPI TX module
> > > 
> > > Signed-off-by: shaoming chen <shaoming.chen@mediatek.com>
> > > Signed-off-by: YT Shen <yt.shen@mediatek.com>
> > > ---
> > 
> > I think the description is too simple. Please briefly describe WHY of
> > this patch. The original enable/disable flow is workable, so why do you
> > need this patch? Without this patch, what problem would happen?
> Got it, we will update more descriptions in the next version.
> There is no transfer/interrupt function in the upstream DSI driver.
> We also implement the following function [1][2] in this patch series.
> 
> Original flow works on there is a bridge chip: DSI -> bridge -> panel.
> In this case: DSI -> panel, the DSI sub driver flow should be updated.
> We need to initialize DSI first so that we can send commands to panel.
> 
> [1] https://patchwork.kernel.org/patch/9310819/
> drm/mediatek: add dsi interrupt control
> [2] https://patchwork.kernel.org/patch/9310823/
> drm/mediatek: add dsi transfer function
> 

I suggest you to separate "DSI directly connect to panel" related
patches to another series because MT8173 could also apply it and it is
not essential for MT2701 if MT2701 use bridge IC for dsi.

Regards,
CK

> > 
> > Regards,
> > CK
> > 
> > 
> 
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v7 8/9] drm/mediatek: update DSI sub driver flow YT Shen <yt.shen@mediatek.com> - 2016-09-12 12:20 +0200
  Re: [PATCH v7 8/9] drm/mediatek: update DSI sub driver flow CK Hu <ck.hu@mediatek.com> - 2016-09-13 12:00 +0200

csiph-web