Re: [PATCH] pinctrl: ret needs to be an int for -ve return value from regmap_update_bits

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] pinctrl: ret needs to be an int for -ve return value from regmap_update_bits
Date	2016-09-13 10:50 +0200
Message-ID	<sgRzH-7TC-5@gated-at.bofh.it> (permalink)
References	<sg8sV-3Vj-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Sep 11, 2016 at 10:36 AM, Colin King <colin.king@canonical.com> wrote:

> From: Colin Ian King <colin.king@canonical.com>
>
> Macro regmap_update_bits can return a -ve on an error value so ret
> needs to be an integer rather than a bool type.
>
> Fixes warning found by static analysis with cppcheck:
> [drivers/pinctrl/aspeed/pinctrl-aspeed.c:192]: (warning) Comparison of
>   a boolean expression with an integer other than 0 or 1.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Dropping this but added your Reported-by to Arnds patch.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] pinctrl: ret needs to be an int for -ve return value from regmap_update_bits Colin King <colin.king@canonical.com> - 2016-09-11 10:40 +0200
  Re: [PATCH] pinctrl: ret needs to be an int for -ve return value  from regmap_update_bits Andrew Jeffery <andrew@aj.id.au> - 2016-09-12 04:10 +0200
  Re: [PATCH] pinctrl: ret needs to be an int for -ve return value from regmap_update_bits Linus Walleij <linus.walleij@linaro.org> - 2016-09-13 10:50 +0200

csiph-web