Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1482236
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk() |
| Date | 2016-09-13 10:20 +0200 |
| Message-ID | <sgR6F-7I4-3@gated-at.bofh.it> (permalink) |
| References | <qEuGl-43C-5@gated-at.bofh.it> <sgEsN-76N-5@gated-at.bofh.it> <sgEsN-76N-3@gated-at.bofh.it> <sgQX0-7Cf-27@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
>> @@ -1064,7 +1064,7 @@ static int rbd_header_from_disk(struct rbd_device *rbd_dev, >> header->snap_sizes = snap_sizes; >> >> return 0; >> -out_2big: >> + out_2big: >> ret = -EIO; >> kfree(snap_sizes); >> free_names: … > Can you point where this current convention is documented? Yes. https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/Documentation/CodingStyle?id=865a1caa4b6b886babdd9d67e7c3608be4567a51 Do you find the software update "CodingStyle: Clarify and complete chapter 7" interesting? > Certainly not in CodingStyle, AFAICT... I suggest to look at the current version once more. > I know some people prefer a single space in there because it makes > "diff -p" work better, but nowadays with "git diff" this argument is > pretty moot. Would you like to discuss the corresponding software evolution a bit more? Regards, Markus
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-12 20:50 +0200
Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk() Ilya Dryomov <idryomov@gmail.com> - 2016-09-13 10:10 +0200
Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-09-13 10:20 +0200
Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk() Ilya Dryomov <idryomov@gmail.com> - 2016-09-13 11:20 +0200
Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk() Jean Delvare <jdelvare@suse.de> - 2016-09-13 16:40 +0200
Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk() Ilya Dryomov <idryomov@gmail.com> - 2016-09-13 17:40 +0200
Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk() Jean Delvare <jdelvare@suse.de> - 2016-09-13 19:00 +0200
Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk() Ilya Dryomov <idryomov@gmail.com> - 2016-09-13 20:40 +0200
Re: [PATCH 03/47] block-rbd: Adjust the position of a jump label in rbd_header_from_disk() Jean Delvare <jdelvare@suse.de> - 2016-09-19 11:40 +0200
csiph-web