Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1482220
| From | Namhyung Kim <namhyung@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 3/7] perf hist: Initialize hierachy tree explicitly |
| Date | 2016-09-13 09:50 +0200 |
| Message-ID | <sgQDD-7fb-13@gated-at.bofh.it> (permalink) |
| References | <sgQDD-7fb-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
The hroot_in and hroot_out are root of hiearchy tree of hist entry. But as hist entry is initialized by copying existing template entry, it sometimes has non-empty tree and copied it incorrectly. This is a problem especially when event group is used since it creates dummy entries from already-processed entries in other event members. Signed-off-by: Namhyung Kim <namhyung@kernel.org> --- tools/perf/util/hist.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c index 702ba3a8ead6..37a08f20730a 100644 --- a/tools/perf/util/hist.c +++ b/tools/perf/util/hist.c @@ -417,6 +417,8 @@ static int hist_entry__init(struct hist_entry *he, } INIT_LIST_HEAD(&he->pairs.node); thread__get(he->thread); + he->hroot_in = RB_ROOT; + he->hroot_out = RB_ROOT; if (!symbol_conf.report_hierarchy) he->leaf = true; -- 2.9.3
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCHSET 0/7] perf tools: Support hierarchy report with event group (v2) Namhyung Kim <namhyung@kernel.org> - 2016-09-13 09:50 +0200
[PATCH 3/7] perf hist: Initialize hierachy tree explicitly Namhyung Kim <namhyung@kernel.org> - 2016-09-13 09:50 +0200
[tip:perf/core] perf hist: Initialize hierarchy tree explicitly tip-bot for Namhyung Kim <tipbot@zytor.com> - 2016-09-20 23:50 +0200
[PATCH 2/7] perf hist: Introduce hists__link_hierarchy() Namhyung Kim <namhyung@kernel.org> - 2016-09-13 09:50 +0200
Re: [PATCH 2/7] perf hist: Introduce hists__link_hierarchy() Jiri Olsa <jolsa@redhat.com> - 2016-09-19 10:10 +0200
Re: [PATCH 2/7] perf hist: Introduce hists__link_hierarchy() Namhyung Kim <namhyung@kernel.org> - 2016-09-20 03:20 +0200
[tip:perf/core] perf hists: Introduce hists__link_hierarchy() tip-bot for Namhyung Kim <tipbot@zytor.com> - 2016-09-20 23:50 +0200
csiph-web