Re: [PATCH] crypto: qce: Initialize core src clock @100Mhz

From	Bjorn Andersson <bjorn.andersson@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] crypto: qce: Initialize core src clock @100Mhz
Date	2016-09-13 06:10 +0200
Message-ID	<sgNcJ-4Tl-5@gated-at.bofh.it> (permalink)
References	<sdmiK-7Ks-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat 03 Sep 09:45 PDT 2016, Iaroslav Gridin wrote:

> Without that, QCE performance is about 2x less.
> 
> Signed-off-by: Iaroslav Gridin <voker57@gmail.com>
> ---
>  drivers/crypto/qce/core.c | 18 +++++++++++++++++-
>  drivers/crypto/qce/core.h |  2 +-
>  2 files changed, 18 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/crypto/qce/core.c b/drivers/crypto/qce/core.c
[..]
> @@ -205,10 +209,20 @@ static int qce_crypto_probe(struct platform_device *pdev)
>  	if (IS_ERR(qce->bus))
>  		return PTR_ERR(qce->bus);
>  
> -	ret = clk_prepare_enable(qce->core);
> +	ret = clk_prepare_enable(qce->core_src);
>  	if (ret)
>  		return ret;
>  
> +	ret = clk_set_rate(qce->core_src, 100000000);
> +	if (ret) {
> +		dev_warn(qce->dev, "Unable to set QCE core src clk @100Mhz, performance might be degraded\n");

This warning is misleading as you return a failure from probe() when it
happens.

> +		goto err_clks_core_src;
> +	}
> +
[..]
> +err_clks_core_src:
> +	clk_disable_unprepare(qce->core_src);
>  	return ret;
>  }
>  

Regards,
Bjorn

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] crypto: qce: Initialize core src clock @100Mhz Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-09-13 06:10 +0200

csiph-web