Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1482065
| From | Namhyung Kim <namhyung@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/7] perf hist: Introduce hists__match_hierarchy() |
| Date | 2016-09-13 02:10 +0200 |
| Message-ID | <sgJst-2kR-7@gated-at.bofh.it> (permalink) |
| References | <sgsUF-852-1@gated-at.bofh.it> <sgsUF-852-9@gated-at.bofh.it> <sgApc-4s1-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi Arnaldo,
On Mon, Sep 12, 2016 at 11:25:30AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Mon, Sep 12, 2016 at 03:19:53PM +0900, Namhyung Kim escreveu:
> > The hists__match_hierarchy() is to find matching hist entries in a
> > group. It needs to search all matching children in the hierarchy.
>
> Can you please enrich this changeset log? Define "matching", an example
> of how the output of a hierarchy + group would help people trying to
> understand the changes you're making, for instance.
Ok. How about this?
The hists__match_hierarchy() is to find matching hist entries in a
group. A matching entry has same values for all sort keys given.
With event group, a leader event should show other members in a
group. So each entry in the leader should be able to find its pair
entries which have same values. With hierarchy mode, it needs to
search all matching children in a hierarchy.
An example output below:
# Overhead Command / Shared Object / Symbol
# ...................... ..................................
#
25.74% 27.18% sh
19.96% 24.14% libc-2.24.so
9.55% 14.64% [.] __strcmp_sse2
1.54% 0.00% [.] __tfind
1.07% 1.13% [.] _int_malloc
...
In the above example, two overhead were shown - one for leader and
another for member. They were matched since their command, dso and
symbol have same values.
Thanks,
Namhyung
>
> > Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> > ---
> > tools/perf/util/hist.c | 51 ++++++++++++++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 51 insertions(+)
> >
> > diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c
> > index de15dbcdcecf..be3f5ce31303 100644
> > --- a/tools/perf/util/hist.c
> > +++ b/tools/perf/util/hist.c
> > @@ -2174,6 +2174,51 @@ static struct hist_entry *hists__find_entry(struct hists *hists,
> > return NULL;
> > }
> >
> > +static struct hist_entry *hists__find_hierarchy_entry(struct rb_root *root,
> > + struct hist_entry *he)
> > +{
> > + struct rb_node *n = root->rb_node;
> > +
> > + while (n) {
> > + struct hist_entry *iter;
> > + struct perf_hpp_fmt *fmt;
> > + int64_t cmp = 0;
> > +
> > + iter = rb_entry(n, struct hist_entry, rb_node_in);
> > + perf_hpp_list__for_each_sort_list(he->hpp_list, fmt) {
> > + cmp = fmt->collapse(fmt, iter, he);
> > + if (cmp)
> > + break;
> > + }
> > +
> > + if (cmp < 0)
> > + n = n->rb_left;
> > + else if (cmp > 0)
> > + n = n->rb_right;
> > + else
> > + return iter;
> > + }
> > +
> > + return NULL;
> > +}
> > +
> > +static void hists__match_hierarchy(struct rb_root *leader_root,
> > + struct rb_root *other_root)
> > +{
> > + struct rb_node *nd;
> > + struct hist_entry *pos, *pair;
> > +
> > + for (nd = rb_first(leader_root); nd; nd = rb_next(nd)) {
> > + pos = rb_entry(nd, struct hist_entry, rb_node_in);
> > + pair = hists__find_hierarchy_entry(other_root, pos);
> > +
> > + if (pair) {
> > + hist_entry__add_pair(pair, pos);
> > + hists__match_hierarchy(&pos->hroot_in, &pair->hroot_in);
> > + }
> > + }
> > +}
> > +
> > /*
> > * Look for pairs to link to the leader buckets (hist_entries):
> > */
> > @@ -2183,6 +2228,12 @@ void hists__match(struct hists *leader, struct hists *other)
> > struct rb_node *nd;
> > struct hist_entry *pos, *pair;
> >
> > + if (symbol_conf.report_hierarchy) {
> > + /* hierarchy report always collapses entries */
> > + return hists__match_hierarchy(&leader->entries_collapsed,
> > + &other->entries_collapsed);
> > + }
> > +
> > if (hists__has(leader, need_collapse))
> > root = &leader->entries_collapsed;
> > else
> > --
> > 2.9.3
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCHSET 0/7] perf tools: Support hierarchy report with event group (v1) Namhyung Kim <namhyung@kernel.org> - 2016-09-12 08:30 +0200
[PATCH 4/7] perf hist: Initialize hierachy tree explicitly Namhyung Kim <namhyung@kernel.org> - 2016-09-12 08:30 +0200
Re: [PATCH 4/7] perf hist: Initialize hierachy tree explicitly Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-09-12 16:30 +0200
Re: [PATCH 4/7] perf hist: Initialize hierachy tree explicitly Namhyung Kim <namhyung@kernel.org> - 2016-09-13 02:10 +0200
[PATCH 6/7] perf ui/tui: Reset output width for hierarchy Namhyung Kim <namhyung@kernel.org> - 2016-09-12 08:30 +0200
Re: [PATCH 6/7] perf ui/tui: Reset output width for hierarchy Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-09-12 16:30 +0200
Re: [PATCH 6/7] perf ui/tui: Reset output width for hierarchy Namhyung Kim <namhyung@kernel.org> - 2016-09-13 03:10 +0200
[PATCH 3/7] perf hist: Introduce hists__link_hierarchy() Namhyung Kim <namhyung@kernel.org> - 2016-09-12 08:30 +0200
[PATCH 1/7] perf hists browser: Fix event group display Namhyung Kim <namhyung@kernel.org> - 2016-09-12 08:30 +0200
Re: [PATCH 1/7] perf hists browser: Fix event group display Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-09-12 16:30 +0200
[tip:perf/core] perf hists browser: Fix event group display tip-bot for Namhyung Kim <tipbot@zytor.com> - 2016-09-20 23:40 +0200
[PATCH 2/7] perf hist: Introduce hists__match_hierarchy() Namhyung Kim <namhyung@kernel.org> - 2016-09-12 08:30 +0200
Re: [PATCH 2/7] perf hist: Introduce hists__match_hierarchy() Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-09-12 16:30 +0200
Re: [PATCH 2/7] perf hist: Introduce hists__match_hierarchy() Namhyung Kim <namhyung@kernel.org> - 2016-09-13 02:10 +0200
[PATCH 7/7] perf report: Enable group view with hierarchy Namhyung Kim <namhyung@kernel.org> - 2016-09-12 08:30 +0200
Re: [PATCH 7/7] perf report: Enable group view with hierarchy Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-09-12 16:30 +0200
Re: [PATCH 7/7] perf report: Enable group view with hierarchy Namhyung Kim <namhyung@kernel.org> - 2016-09-13 03:10 +0200
[PATCH 5/7] perf ui/stdio: Reset output width for hierarchy Namhyung Kim <namhyung@kernel.org> - 2016-09-12 08:30 +0200
Re: [PATCH 5/7] perf ui/stdio: Reset output width for hierarchy Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-09-12 16:30 +0200
Re: [PATCH 5/7] perf ui/stdio: Reset output width for hierarchy Namhyung Kim <namhyung@kernel.org> - 2016-09-13 03:10 +0200
csiph-web