Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1481543
| From | Leo Li <pku.leo@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v5] i2c: imx: make bus recovery through pinctrl optional |
| Date | 2016-09-12 18:50 +0200 |
| Message-ID | <sgCAG-5NW-35@gated-at.bofh.it> (permalink) |
| References | (6 earlier) <sfhoB-3WL-11@gated-at.bofh.it> <sfxjI-5u3-25@gated-at.bofh.it> <sfzOy-71n-23@gated-at.bofh.it> <sfAUh-7Iw-19@gated-at.bofh.it> <sfB3X-7LQ-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Sep 9, 2016 at 3:59 PM, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > Hello, > > On Fri, Sep 09, 2016 at 01:34:31PM -0700, Stefan Agner wrote: >> Yeah it is a bit a wording thing: In my understanding, pinctrl is >> required on SoC's witch have a pin controller... It is just that the >> driver does not need to get the pinctrl by itself because the stack is >> taking care of it implicitly. And yes, that makes the particular example >> not a real world example. > > At first I thought, too, that it's a fatal problem if getting the > pinctrl stuff fails. IMHO that shows that the comments (or the code) are > still not good enough. Ya. If it has confused more than one people, it is likely to confuse more. I agree with you that we should make it more clear. Thanks, Leo
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH v5] i2c: imx: make bus recovery through pinctrl optional Stefan Agner <stefan@agner.ch> - 2016-09-09 19:00 +0200
Re: [PATCH v5] i2c: imx: make bus recovery through pinctrl optional Leo Li <pku.leo@gmail.com> - 2016-09-09 21:40 +0200
Re: [PATCH v5] i2c: imx: make bus recovery through pinctrl optional Stefan Agner <stefan@agner.ch> - 2016-09-09 22:50 +0200
Re: [PATCH v5] i2c: imx: make bus recovery through pinctrl optional Uwe Kleine-König <u.kleine-koenig@pengutronix.de> - 2016-09-09 23:00 +0200
Re: [PATCH v5] i2c: imx: make bus recovery through pinctrl optional Leo Li <pku.leo@gmail.com> - 2016-09-12 18:50 +0200
Re: [PATCH v5] i2c: imx: make bus recovery through pinctrl optional Lothar Waßmann <LW@KARO-electronics.de> - 2016-09-12 10:30 +0200
Re: [PATCH v5] i2c: imx: make bus recovery through pinctrl optional Leo Li <pku.leo@gmail.com> - 2016-09-12 18:30 +0200
csiph-web