RE: [PATCH for-next 09/20] IB/hns: Optimize code of aeq and ceq interrupt handle and fix the bug of qpn

From	Salil Mehta <salil.mehta@huawei.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH for-next 09/20] IB/hns: Optimize code of aeq and ceq interrupt handle and fix the bug of qpn
Date	2016-09-12 17:50 +0200
Message-ID	<sgBED-5cu-45@gated-at.bofh.it> (permalink)
References	<sfr4B-1xy-3@gated-at.bofh.it> <sfr4C-1xy-41@gated-at.bofh.it> <sgyGK-3jx-35@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


> -----Original Message-----
> From: Leon Romanovsky [mailto:leon@kernel.org]
> Sent: Monday, September 12, 2016 1:33 PM
> To: Salil Mehta
> Cc: dledford@redhat.com; Huwei (Xavier); oulijun; Zhuangyuzeng (Yisen);
> xuwei (O); mehta.salil.lnk@gmail.com; linux-rdma@vger.kernel.org;
> linux-kernel@vger.kernel.org; Linuxarm
> Subject: Re: [PATCH for-next 09/20] IB/hns: Optimize code of aeq and
> ceq interrupt handle and fix the bug of qpn
> 
> On Fri, Sep 09, 2016 at 06:30:40PM +0800, Salil Mehta wrote:
> 
> ....
> 
> > +			     HNS_ROCE_AEQE_EVENT_QP_EVENT_QP_QPN_M,
> > +			     HNS_ROCE_AEQE_EVENT_QP_EVENT_QP_QPN_S);
> > +	phy_port = roce_get_field(aeqe->event.qp_event.qp,
> > +			HNS_ROCE_AEQE_EVENT_QP_EVENT_PORT_NUM_M,
> > +			HNS_ROCE_AEQE_EVENT_QP_EVENT_PORT_NUM_S);
> > +	if (qpn <= 1)
> > +		qpn = HNS_ROCE_MAX_PORTS * qpn + phy_port;
> > +
> > +	switch (event_type) {
> > +	case HNS_ROCE_EVENT_TYPE_INV_REQ_LOCAL_WQ_ERROR:
> > +		dev_warn(dev, "Invalid Req Local Work Queue Error.\n");
> > +		dev_warn(dev, "QP %d, phy_port %d.\n", qpn, phy_port);
> 
> dev_warn like all other printk flavours supports multi-line messages.
Yes, agreed. This can be done using single dev_warn as well, like below:
dev_warn(dev,
         "Invalid Req Local Work Queue Error.\n"
         "QP %d, phy_port %d.\n", qpn, phy_port);

Will change and refloat the patch.

Thanks
Salil
> 
> > +		break;

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH for-next 09/20] IB/hns: Optimize code of aeq and ceq  interrupt handle and fix the bug of qpn Leon Romanovsky <leon@kernel.org> - 2016-09-12 14:40 +0200
  RE: [PATCH for-next 09/20] IB/hns: Optimize code of aeq and ceq  interrupt handle and fix the bug of qpn Salil Mehta <salil.mehta@huawei.com> - 2016-09-12 17:50 +0200

csiph-web