Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1481363
| From | David Ahern <dsa@cumulusnetworks.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] net: inet: diag: Fix an error handling |
| Date | 2016-09-12 16:40 +0200 |
| Message-ID | <sgAyS-4vI-49@gated-at.bofh.it> (permalink) |
| References | <sgsBj-7Yg-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 9/12/16 12:02 AM, Christophe JAILLET wrote:
> diff --git a/net/ipv4/inet_diag.c b/net/ipv4/inet_diag.c
> index abfbe492ebfe..795af25cf84c 100644
> --- a/net/ipv4/inet_diag.c
> +++ b/net/ipv4/inet_diag.c
> @@ -1134,7 +1134,6 @@ int inet_diag_handler_get_info(struct sk_buff *skb, struct sock *sk)
>
> handler = inet_diag_lock_handler(sk->sk_protocol);
> if (IS_ERR(handler)) {
> - inet_diag_unlock_handler(handler);
> nlmsg_cancel(skb, nlh);
> return PTR_ERR(handler);
> }
>
That call is needed. inet_diag_unlock_handler does not operate on the input arg but a global mutex. Perhaps a better patch is to change inet_diag_unlock_handler() to a void.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] net: inet: diag: Fix an error handling Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2016-09-12 08:10 +0200
Re: [PATCH] net: inet: diag: Fix an error handling David Ahern <dsa@cumulusnetworks.com> - 2016-09-12 16:40 +0200
Re: [PATCH] net: inet: diag: Fix an error handling Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2016-09-12 20:30 +0200
csiph-web