Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1481353
| Path | csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | Russell King - ARM Linux <linux@armlinux.org.uk> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH][V2] dma-mapping: add in missing white space in error message text |
| Date | Mon, 12 Sep 2016 16:30:02 +0200 |
| Message-ID | <sgApc-4s1-7@gated-at.bofh.it> (permalink) |
| References | <sgzjr-3N9-11@gated-at.bofh.it> |
| X-Original-To | Colin King <colin.king@canonical.com> |
| Dkim-Signature | v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2014; h=Sender:In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=RrY9nZDoLnd0ginP8imkP9hRsOZUlIwuiDi7SJOlQbw=; b=UYWvfY5g246rBm4bf0yQ9kn6rMqVZmXIE10m8J3LtWw0bmZk8+kWzmA/ZD6VVfW7wJ3HdnvXSs10bxIwt0KPGzBehnnPq0gkuH9hWh5OW/wkB0+P8+Td8DR3UDjrtkAlLWZ3GcInq2MiB5cfOTVlOMAX+FfTujIexqUisM8Dlw8=; |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=us-ascii |
| Content-Disposition | inline |
| User-Agent | Mutt/1.5.23 (2014-03-12) |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 37 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Vineet Gupta <vgupta@synopsys.com>, Hans-Christian Noren Egtvedt <egtvedt@samfundet.no>, Joerg Roedel <jroedel@suse.de>, Robin Murphy <robin.murphy@arm.com>, Jesper Nilsson <jesper.nilsson@axis.com>, Krzysztof Kozlowski <krzk@kernel.org>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org |
| X-Original-Date | Mon, 12 Sep 2016 15:28:50 +0100 |
| X-Original-Message-ID | <20160912142849.GV1041@n2100.armlinux.org.uk> |
| X-Original-References | <20160912130952.2778-1-colin.king@canonical.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1481353 |
Show key headers only | View raw
On Mon, Sep 12, 2016 at 02:09:52PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> A dev_warn message spans two lines and the literal string is missing
> a white space between words. Add the white space and reformat the
> message to not span multiple lines.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> arch/arm/common/dmabounce.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/arch/arm/common/dmabounce.c b/arch/arm/common/dmabounce.c
> index 3012816..afeb5e3 100644
> --- a/arch/arm/common/dmabounce.c
> +++ b/arch/arm/common/dmabounce.c
> @@ -546,9 +546,7 @@ void dmabounce_unregister_dev(struct device *dev)
> set_dma_ops(dev, NULL);
>
> if (!device_info) {
> - dev_warn(dev,
> - "Never registered with dmabounce but attempting"
> - "to unregister!\n");
> + dev_warn(dev, "Never registered with dmabounce but attempting to unregister!\n");
Almost!
dev_warn(dev,
"Never registered with dmabounce but attempting to unregister!\n");
The point is that the string is as greppable as possible, while trying to
keep to the rest of the style.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH][V2] dma-mapping: add in missing white space in error message text Colin King <colin.king@canonical.com> - 2016-09-12 15:20 +0200 Re: [PATCH][V2] dma-mapping: add in missing white space in error message text Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-09-12 16:30 +0200
csiph-web