Re: [PATCH 3/3] drivers: Add visorbus to the drivers/virt directory

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	'Greg KH' <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] drivers: Add visorbus to the drivers/virt directory
Date	Sun, 11 Sep 2016 11:20:01 +0200
Message-ID	<sg95D-4nu-5@gated-at.bofh.it> (permalink)
References	<rIHMt-6a4-1@gated-at.bofh.it> <rIHMt-6a4-3@gated-at.bofh.it> <s8IDg-5Jn-25@gated-at.bofh.it> <sbUox-7nH-29@gated-at.bofh.it>
X-Original-To	"Sell, Timothy C" <Timothy.Sell@unisys.com>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.7.0 (2016-08-17)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	25
Organization	linux.* mail to news gateway
X-Original-Cc	"Kershner, David A" <David.Kershner@unisys.com>, "dzickus@redhat.com" <dzickus@redhat.com>, "prarit@redhat.com" <prarit@redhat.com>, "driverdev-devel@linuxdriverproject.org" <driverdev-devel@linuxdriverproject.org>, *S-Par-Maintainer <SParMaintainer@unisys.com>, "janani.rvchndrn@gmail.com" <janani.rvchndrn@gmail.com>, "corbet@lwn.net" <corbet@lwn.net>, "jes.sorensen@redhat.com" <jes.sorensen@redhat.com>, "Binder, David Anthony" <David.Binder@unisys.com>, "hofrat@osadl.org" <hofrat@osadl.org>, "dan.j.williams@intel.com" <dan.j.williams@intel.com>, "nhorman@redhat.com" <nhorman@redhat.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "mingo@redhat.com" <mingo@redhat.com>, "hpa@zytor.com" <hpa@zytor.com>, "tglx@linutronix.de" <tglx@linutronix.de>, "sudipm.mukherjee@gmail.com" <sudipm.mukherjee@gmail.com>, "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>
X-Original-Date	Sun, 11 Sep 2016 11:16:29 +0200
X-Original-Message-ID	<20160911091629.GA17608@kroah.com>
X-Original-References	<1465615436-16035-1-git-send-email-david.kershner@unisys.com> <1465615436-16035-4-git-send-email-david.kershner@unisys.com> <20160821180458.GA10469@kroah.com> <BN3PR07MB2580D297D0A1E38E9ED3AD34FCE00@BN3PR07MB2580.namprd07.prod.outlook.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1480759

Show key headers only | View raw

On Tue, Aug 30, 2016 at 04:29:07PM +0000, Sell, Timothy C wrote:
> E.g., so even though no obvious error-recovery occurs above in-response to
> kzalloc() failures, the fact that -CONTROLVM_RESP_ERROR_KMALLOC_FAILED is
> provided to bus_epilog() is in-fact sufficient to report the error.
> 
> Is this making sense?

Yes, it does a bit more, but, you should make this more explicit.

> Can you suggest how we might modify our code to make this error-handling /
> recovery strategy clearer?

Have a real error be returned by the function, and then have the caller
handle the error by propagating it back to the firmware through the
message.  That might save you a lot of boiler-plate error handling logic
as well, right?

That will make it obvious that if an error happens, it is caught, and
how it is handled correctly.

Does that help?

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 3/3] drivers: Add visorbus to the drivers/virt directory 'Greg KH' <gregkh@linuxfoundation.org> - 2016-09-11 11:20 +0200
  RE: [PATCH 3/3] drivers: Add visorbus to the drivers/virt directory "Sell, Timothy C" <Timothy.Sell@unisys.com> - 2016-09-11 17:20 +0200

csiph-web