Re: [alsa-devel] [PATCH] ASoC: Intel: remove status, it is shadowing status of a higher scope

From	Colin Ian King <colin.king@canonical.com>
Newsgroups	linux.kernel
Subject	Re: [alsa-devel] [PATCH] ASoC: Intel: remove status, it is shadowing status of a higher scope
Date	2016-09-09 19:20 +0200
Message-ID	<sfxD4-5Pj-9@gated-at.bofh.it> (permalink)
References	<sfq8x-Za-1@gated-at.bofh.it> <sfxtn-5M5-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 09/09/16 18:04, Pierre-Louis Bossart wrote:
> On 9/9/16 2:09 AM, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> The second declaration of status is shadowing the status of a higher
>> scope.  This uninitialized status results in garbage being returned
>> by the !x86_match_cpu(cpu_ids) || !iosf_mbi_available() return exit
>> path.  Fix this by removing the extraneous second declaration of
>> status.
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> 
> Gah... thanks for correcting this, not sure how I missed it, was there a
> compiler warning?

static analysis tools, this time CoverityScan

> Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> 
>> ---
>>  sound/soc/intel/atom/sst/sst_acpi.c | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/sound/soc/intel/atom/sst/sst_acpi.c
>> b/sound/soc/intel/atom/sst/sst_acpi.c
>> index 773acfb..4c14215 100644
>> --- a/sound/soc/intel/atom/sst/sst_acpi.c
>> +++ b/sound/soc/intel/atom/sst/sst_acpi.c
>> @@ -249,7 +249,6 @@ static int is_byt_cr(struct device *dev, bool *bytcr)
>>              { X86_VENDOR_INTEL, 6, 55 }, /* Valleyview, Bay Trail */
>>              {}
>>          };
>> -        int status;
>>          u32 bios_status;
>>
>>          if (!x86_match_cpu(cpu_ids) || !iosf_mbi_available()) {
>>
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ASoC: Intel: remove status, it is shadowing status of a higher scope Colin King <colin.king@canonical.com> - 2016-09-09 11:20 +0200
  Re: [alsa-devel] [PATCH] ASoC: Intel: remove status, it is shadowing  status of a higher scope Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> - 2016-09-09 19:10 +0200
    Re: [alsa-devel] [PATCH] ASoC: Intel: remove status, it is shadowing  status of a higher scope Colin Ian King <colin.king@canonical.com> - 2016-09-09 19:20 +0200

csiph-web