Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1480127
| From | Nayeemahmed Badebade <itachi.opsrc@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH] staging: lustre: lustre/ldlm: Fixed sparse warnings |
| Date | 2016-09-09 17:30 +0200 |
| Message-ID | <sfvUC-4IV-45@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
Added __acquires / __releases sparse locking annotations
to lock_res_and_lock and unlock_res_and_lock functions in
l_lock.c, to fix below sparse warnings:
l_lock.c:47:22: warning: context imbalance in 'lock_res_and_lock' - wrong count at exit
l_lock.c:62:6: warning: context imbalance in 'unlock_res_and_lock' - unexpected unlock
Signed-off-by: Nayeemahmed Badebade <itachi.opsrc@gmail.com>
---
drivers/staging/lustre/lustre/ldlm/l_lock.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/staging/lustre/lustre/ldlm/l_lock.c b/drivers/staging/lustre/lustre/ldlm/l_lock.c
index ea8840c..c4b9612 100644
--- a/drivers/staging/lustre/lustre/ldlm/l_lock.c
+++ b/drivers/staging/lustre/lustre/ldlm/l_lock.c
@@ -45,6 +45,8 @@
* being an atomic operation.
*/
struct ldlm_resource *lock_res_and_lock(struct ldlm_lock *lock)
+ __acquires(&lock->l_lock)
+ __acquires(lock->l_resource)
{
spin_lock(&lock->l_lock);
@@ -59,6 +61,8 @@ EXPORT_SYMBOL(lock_res_and_lock);
* Unlock a lock and its resource previously locked with lock_res_and_lock
*/
void unlock_res_and_lock(struct ldlm_lock *lock)
+ __releases(lock->l_resource)
+ __releases(&lock->l_lock)
{
/* on server-side resource of lock doesn't change */
ldlm_clear_res_locked(lock);
--
1.9.1
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH] staging: lustre: lustre/ldlm: Fixed sparse warnings Nayeemahmed Badebade <itachi.opsrc@gmail.com> - 2016-09-09 17:30 +0200
Re: [PATCH] staging: lustre: lustre/ldlm: Fixed sparse warnings Greg KH <gregkh@linuxfoundation.org> - 2016-09-12 12:30 +0200
Re: [PATCH] staging: lustre: lustre/ldlm: Fixed sparse warnings "Dilger, Andreas" <andreas.dilger@intel.com> - 2016-09-14 07:20 +0200
Re: [PATCH] staging: lustre: lustre/ldlm: Fixed sparse warnings nayeem <itachi.opsrc@gmail.com> - 2016-09-15 20:40 +0200
Re: [PATCH] staging: lustre: lustre/ldlm: Fixed sparse warnings "Dilger, Andreas" <andreas.dilger@intel.com> - 2016-09-16 10:10 +0200
Re: [PATCH] staging: lustre: lustre/ldlm: Fixed sparse warnings nayeem <itachi.opsrc@gmail.com> - 2016-09-18 22:30 +0200
Re: [PATCH] staging: lustre: lustre/ldlm: Fixed sparse warnings "Dilger, Andreas" <andreas.dilger@intel.com> - 2016-09-18 22:40 +0200
[PATCH v2] staging: lustre: lustre/ldlm: Fixed sparse warnings Nayeemahmed Badebade <itachi.opsrc@gmail.com> - 2016-09-18 23:20 +0200
Re: [PATCH v2] staging: lustre: lustre/ldlm: Fixed sparse warnings "Dilger, Andreas" <andreas.dilger@intel.com> - 2016-09-18 23:30 +0200
Re: [PATCH v2] staging: lustre: lustre/ldlm: Fixed sparse warnings James Simmons <jsimmons@infradead.org> - 2016-09-19 22:50 +0200
csiph-web