Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1479974

Re: [PATCH] EDAC: sb_edac: remove null pointer check on array pci_tad

Show all headers | View raw

+ Tony.

On Thu, Sep 08, 2016 at 09:38:01AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> pvt->pci_tad is a NUM_CHANNELS array of struct pci_dev pointers and
> hence cannot be null, so the pull pointer check on pci_tad is
> redundant.  Remove it.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/edac/sb_edac.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/edac/sb_edac.c b/drivers/edac/sb_edac.c
> index ce0067b..5477522 100644
> --- a/drivers/edac/sb_edac.c
> +++ b/drivers/edac/sb_edac.c
> @@ -2474,7 +2474,7 @@ static int sbridge_mci_bind_devs(struct mem_ctl_info *mci,
>  
>  	/* Check if everything were registered */
>  	if (!pvt->pci_sad0 || !pvt->pci_sad1 || !pvt->pci_ha0 ||
> -	    !pvt-> pci_tad || !pvt->pci_ras  || !pvt->pci_ta)
> +	    !pvt->pci_ras || !pvt->pci_ta)
>  		goto enodev;
>  
>  	if (saw_chan_mask != 0x0f)
> @@ -2563,8 +2563,7 @@ static int ibridge_mci_bind_devs(struct mem_ctl_info *mci,
>  
>  	/* Check if everything were registered */
>  	if (!pvt->pci_sad0 || !pvt->pci_ha0 || !pvt->pci_br0 ||
> -	    !pvt->pci_br1 || !pvt->pci_tad || !pvt->pci_ras  ||
> -	    !pvt->pci_ta)
> +	    !pvt->pci_br1 || !pvt->pci_ras || !pvt->pci_ta)
>  		goto enodev;
>  
>  	if (saw_chan_mask != 0x0f && /* -EN */
> -- 
> 2.9.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-edac" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] EDAC: sb_edac: remove null pointer check on array pci_tad Colin King <colin.king@canonical.com> - 2016-09-08 10:50 +0200
  Re: [PATCH] EDAC: sb_edac: remove null pointer check on array pci_tad Borislav Petkov <bp@alien8.de> - 2016-09-09 15:00 +0200
  Re: [PATCH] EDAC: sb_edac: remove null pointer check on array pci_tad Borislav Petkov <bp@alien8.de> - 2016-09-12 20:40 +0200

csiph-web