Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1479804

Re: [PATCH] [media] pci: constify vb2_ops structures

From Julia Lawall <Julia.Lawall@lip6.fr>
Newsgroups linux.kernel
Subject Re: [PATCH] [media] pci: constify vb2_ops structures
Date 2016-09-09 11:50 +0200
Message-ID <sfqBA-18C-5@gated-at.bofh.it> (permalink)
References <sfhHX-4i4-11@gated-at.bofh.it> <sfq8x-Za-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Le 09.09.2016 17:17, Andrey Utkin a écrit :
> On Fri, Sep 09, 2016 at 01:59:18AM +0200, Julia Lawall wrote:
>> Check for vb2_ops structures that are only stored in the ops field of 
>> a
>> vb2_queue structure.  That field is declared const, so vb2_ops 
>> structures
>> that have this property can be declared as const also.
> 
>> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>> 
>> ---
>>  drivers/media/pci/cx23885/cx23885-417.c            |    2 +-
>>  drivers/media/pci/cx23885/cx23885-dvb.c            |    2 +-
>>  drivers/media/pci/cx23885/cx23885-video.c          |    2 +-
>>  drivers/media/pci/cx25821/cx25821-video.c          |    2 +-
>>  drivers/media/pci/cx88/cx88-blackbird.c            |    2 +-
>>  drivers/media/pci/cx88/cx88-dvb.c                  |    2 +-
>>  drivers/media/pci/cx88/cx88-video.c                |    2 +-
>>  drivers/media/pci/netup_unidvb/netup_unidvb_core.c |    2 +-
>>  drivers/media/pci/saa7134/saa7134-empress.c        |    2 +-
>>  drivers/media/pci/saa7134/saa7134-video.c          |    2 +-
>>  drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c     |    2 +-
>>  drivers/media/pci/tw68/tw68-video.c                |    2 +-
>>  drivers/media/pci/tw686x/tw686x-video.c            |    2 +-
>>  13 files changed, 13 insertions(+), 13 deletions(-)
> 
> Applies and compiles cleanly on media tree.
> But please regenerate this patch on git://linuxtv.org/media_tree.git -
> it has a new driver by me, drivers/media/pci/tw5864 , which is 
> affected.

Do you want the whole patch again, or would a patch on the new driver by 
itself be sufficient?  The changes in the different files are all 
independent.

julia

> Otherwise
> 
> Acked-by: Andrey Utkin <andrey.utkin@corp.bluecherry.net>
> 
> (however this time I'm writing from another email.)
> --
> To unsubscribe from this list: send the line "unsubscribe 
> kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] [media] pci: constify vb2_ops structures Julia Lawall <Julia.Lawall@lip6.fr> - 2016-09-09 02:20 +0200
  Re: [PATCH] [media] pci: constify vb2_ops structures Andrey Utkin <andrey_utkin@fastmail.com> - 2016-09-09 11:20 +0200
    Re: [PATCH] [media] pci: constify vb2_ops structures Julia Lawall <Julia.Lawall@lip6.fr> - 2016-09-09 11:50 +0200
      Re: [PATCH] [media] pci: constify vb2_ops structures andrey_utkin@fastmail.com - 2016-09-09 12:10 +0200
    Re: [PATCH] [media] pci: constify vb2_ops structures Julia Lawall <julia.lawall@lip6.fr> - 2016-09-09 16:40 +0200
      Re: [PATCH] [media] pci: constify vb2_ops structures Andrey Utkin <andrey_utkin@fastmail.com> - 2016-09-09 17:10 +0200
        Re: [PATCH] [media] pci: constify vb2_ops structures Julia Lawall <julia.lawall@lip6.fr> - 2016-09-09 17:30 +0200

csiph-web