Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1479763
| From | Mika Westerberg <mika.westerberg@linux.intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] pinctrl: cherryview: Do not mask all interrupts on probe |
| Date | 2016-09-09 11:00 +0200 |
| Message-ID | <sfpPc-D1-3@gated-at.bofh.it> (permalink) |
| References | (5 earlier) <sf4B3-4xM-3@gated-at.bofh.it> <sf4KK-4Bb-51@gated-at.bofh.it> <sfan8-87F-13@gated-at.bofh.it> <sfnu1-7P4-1@gated-at.bofh.it> <sfpma-tM-25@gated-at.bofh.it> |
| Organization | Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo |
On Fri, Sep 09, 2016 at 04:23:58PM +0800, Phidias Chiang wrote: > On Fri, Sep 09, 2016 at 09:18:34AM +0300, Mika Westerberg wrote: > > On Fri, Sep 09, 2016 at 12:28:43AM +0800, Phidias Chiang wrote: > > > > Hmm, how can that happen? The patch removes clearing of INTMASK and only > > other place where it is cleared temporarily is on resume. Can you add > > dev_info() calls like: > > > > /* Clear all interrupts */ > > chv_writel(0xffff, pctrl->regs + CHV_INTSTAT); > > dev_info(pctrl->dev, "INTMASK0: 0x%08x\n", readl(pctrl->regs + CHV_INTMASK)); > > > > ... > > > > gpiochip_set_chained_irqchip(chip, &chv_gpio_irqchip, irq, > > chv_gpio_irq_handler); > > dev_info(pctrl->dev, "INTMASK1: 0x%08x\n", readl(pctrl->regs + CHV_INTMASK)); > > return 0; > > > > It should print the same values both time. > > > > Also which interrupt does not work and can you send me output of > > /proc/interrupts? > > Output in dmesg: > [ 2.054475] cherryview-pinctrl INT33FF:00: INTMASK0: 0x00000006 > [ 2.055247] cherryview-pinctrl INT33FF:00: INTMASK1: 0x00000000 > [ 2.055375] cherryview-pinctrl INT33FF:01: INTMASK0: 0x00004000 > [ 2.056931] cherryview-pinctrl INT33FF:01: INTMASK1: 0x00000000 > [ 2.057036] cherryview-pinctrl INT33FF:02: INTMASK0: 0x00000000 > [ 2.057367] cherryview-pinctrl INT33FF:02: INTMASK1: 0x00000000 > [ 2.057489] cherryview-pinctrl INT33FF:03: INTMASK0: 0x00000000 > [ 2.058337] cherryview-pinctrl INT33FF:03: INTMASK1: 0x00000000 > > So it's somehow got cleared in the process after. Only other place where we touch INTMASK register is chv_gpio_irq_mask_unmask(). Can you add some debug there to find out the caller? > And the following link is the complete /proc/interrupts: > http://pastebin.com/qwamyKZb Looks quite normal. > THe interrupt doesn't work is 9, when I made it work it responsed to > pressing hotkeys. 9 is the SCI interrupt used by ACPI which explains.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH] pinctrl: cherryview: Do not mask all interrupts on probe Phidias Chiang <phidias.chiang@canonical.com> - 2016-09-08 12:20 +0200
Re: [PATCH] pinctrl: cherryview: Do not mask all interrupts on probe Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-09-08 12:30 +0200
Re: [PATCH] pinctrl: cherryview: Do not mask all interrupts on probe Phidias Chiang <phidias.chiang@canonical.com> - 2016-09-08 18:30 +0200
Re: [PATCH] pinctrl: cherryview: Do not mask all interrupts on probe Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-09-09 08:30 +0200
Re: [PATCH] pinctrl: cherryview: Do not mask all interrupts on probe Phidias Chiang <phidias.chiang@canonical.com> - 2016-09-09 10:30 +0200
Re: [PATCH] pinctrl: cherryview: Do not mask all interrupts on probe Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-09-09 11:00 +0200
Re: [PATCH] pinctrl: cherryview: Do not mask all interrupts on probe Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-09-11 10:10 +0200
Re: [PATCH] pinctrl: cherryview: Do not mask all interrupts on probe Phidias Chiang <phidias.chiang@canonical.com> - 2016-09-12 09:00 +0200
Re: [PATCH] pinctrl: cherryview: Do not mask all interrupts on probe Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-09-12 11:10 +0200
Re: [PATCH] pinctrl: cherryview: Do not mask all interrupts on probe Phidias Chiang <phidias.chiang@canonical.com> - 2016-09-12 15:10 +0200
Re: [PATCH] pinctrl: cherryview: Do not mask all interrupts on probe Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-09-12 15:30 +0200
Re: [PATCH] pinctrl: cherryview: Do not mask all interrupts on probe Linus Walleij <linus.walleij@linaro.org> - 2016-09-13 11:20 +0200
Re: [PATCH] pinctrl: cherryview: Do not mask all interrupts on probe Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-09-13 11:40 +0200
Re: [PATCH] pinctrl: cherryview: Do not mask all interrupts on probe Linus Walleij <linus.walleij@linaro.org> - 2016-09-13 14:30 +0200
Re: [PATCH] pinctrl: cherryview: Do not mask all interrupts on probe Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-09-13 15:00 +0200
Re: [PATCH] pinctrl: cherryview: Do not mask all interrupts on probe Linus Walleij <linus.walleij@linaro.org> - 2016-09-13 23:00 +0200
Re: [PATCH] pinctrl: cherryview: Do not mask all interrupts on probe Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-09-14 10:30 +0200
Re: [PATCH] pinctrl: cherryview: Do not mask all interrupts on probe Linus Walleij <linus.walleij@linaro.org> - 2016-09-14 14:50 +0200
Re: [PATCH] pinctrl: cherryview: Do not mask all interrupts on probe Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-09-14 17:20 +0200
Re: [PATCH] pinctrl: cherryview: Do not mask all interrupts on probe Linus Walleij <linus.walleij@linaro.org> - 2016-09-15 14:50 +0200
Re: [PATCH] pinctrl: cherryview: Do not mask all interrupts on probe Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-09-15 17:50 +0200
[PATCH 2/2] pinctrl: cherryview: Do not add all southwest and north GPIOs to IRQ domain Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-09-15 18:00 +0200
[PATCH 1/2] gpiolib: Add possibility to mask which GPIOs are added to IRQ domain Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-09-15 18:00 +0200
Re: [PATCH 1/2] gpiolib: Add possibility to mask which GPIOs are added to IRQ domain Marc Zyngier <marc.zyngier@arm.com> - 2016-09-15 18:10 +0200
Re: [PATCH 1/2] gpiolib: Add possibility to mask which GPIOs are added to IRQ domain Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-09-15 20:20 +0200
Re: [PATCH 1/2] gpiolib: Add possibility to mask which GPIOs are added to IRQ domain Thomas Gleixner <tglx@linutronix.de> - 2016-09-15 21:00 +0200
Re: [PATCH 1/2] gpiolib: Add possibility to mask which GPIOs are added to IRQ domain Linus Walleij <linus.walleij@linaro.org> - 2016-09-18 13:20 +0200
csiph-web