Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1479759

Re: [PATCH] [media] usb: constify vb2_ops structures

Show all headers | View raw

Hi Julia,

Thank you for the patch.

On Friday 09 Sep 2016 01:59:01 Julia Lawall wrote:
> Check for vb2_ops structures that are only stored in the ops field of a
> vb2_queue structure.  That field is declared const, so vb2_ops structures
> that have this property can be declared as const also.
> 
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @r disable optional_qualifier@
> identifier i;
> position p;
> @@
> static struct vb2_ops i@p = { ... };
> 
> @ok@
> identifier r.i;
> struct vb2_queue e;
> position p;
> @@
> e.ops = &i@p;
> 
> @bad@
> position p != {r.p,ok.p};
> identifier r.i;
> struct vb2_ops e;
> @@
> e@i@p
> 
> @depends on !bad disable optional_qualifier@
> identifier r.i;
> @@
> static
> +const
>  struct vb2_ops i = { ... };
> // </smpl>
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

For

>  drivers/media/usb/uvc/uvc_queue.c       |    2 +-

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

-- 
Regards,

Laurent Pinchart

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] [media] usb: constify vb2_ops structures Julia Lawall <Julia.Lawall@lip6.fr> - 2016-09-09 02:20 +0200
  Re: [PATCH] [media] usb: constify vb2_ops structures Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2016-09-09 10:50 +0200

csiph-web