Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1479681

[RFC PATCH v3 4/7] proc: Reduce cache miss in sctp_snmp_seq_show

Show all headers | View raw

This is to use the generic interface snmp_get_cpu_field{,64}_batch to
aggregate the data by going through all the items of each cpu sequentially.

Signed-off-by: Jia He <hejianet@gmail.com>
---
 net/sctp/proc.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/net/sctp/proc.c b/net/sctp/proc.c
index ef8ba77..0487c01 100644
--- a/net/sctp/proc.c
+++ b/net/sctp/proc.c
@@ -75,11 +75,15 @@ static int sctp_snmp_seq_show(struct seq_file *seq, void *v)
 {
 	struct net *net = seq->private;
 	int i;
+	unsigned long buff[SCTP_MIB_MAX];
 
+	memset(buff, 0, sizeof(unsigned long) * SCTP_MIB_MAX);
+
+	snmp_get_cpu_field_batch(buff, sctp_snmp_list,
+				 net->sctp.sctp_statistics);
 	for (i = 0; sctp_snmp_list[i].name != NULL; i++)
 		seq_printf(seq, "%-32s\t%ld\n", sctp_snmp_list[i].name,
-			   snmp_fold_field(net->sctp.sctp_statistics,
-				      sctp_snmp_list[i].entry));
+						buff[i]);
 
 	return 0;
 }
-- 
1.8.3.1

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH v3 0/7] Reduce cache miss for snmp_fold_field Jia He <hejianet@gmail.com> - 2016-09-09 08:40 +0200
  [RFC PATCH v3 4/7] proc: Reduce cache miss in sctp_snmp_seq_show Jia He <hejianet@gmail.com> - 2016-09-09 08:40 +0200
  [RFC PATCH v3 2/7] proc: Reduce cache miss in {snmp,netstat}_seq_show Jia He <hejianet@gmail.com> - 2016-09-09 08:40 +0200
    Re: [RFC PATCH v3 2/7] proc: Reduce cache miss in  {snmp,netstat}_seq_show Marcelo <marcelo.leitner@gmail.com> - 2016-09-12 21:00 +0200
      Re: [RFC PATCH v3 2/7] proc: Reduce cache miss in  {snmp,netstat}_seq_show hejianet <hejianet@gmail.com> - 2016-09-14 05:20 +0200
      Re: [RFC PATCH v3 2/7] proc: Reduce cache miss in  {snmp,netstat}_seq_show hejianet <hejianet@gmail.com> - 2016-09-14 08:00 +0200
        Re: [RFC PATCH v3 2/7] proc: Reduce cache miss in  {snmp,netstat}_seq_show Marcelo <marcelo.leitner@gmail.com> - 2016-09-14 14:00 +0200
          Re: [RFC PATCH v3 2/7] proc: Reduce cache miss in  {snmp,netstat}_seq_show hejianet <hejianet@gmail.com> - 2016-09-21 19:10 +0200
            Re: [RFC PATCH v3 2/7] proc: Reduce cache miss in  {snmp,netstat}_seq_show Marcelo <marcelo.leitner@gmail.com> - 2016-09-21 20:30 +0200
              Re: [RFC PATCH v3 2/7] proc: Reduce cache miss in  {snmp,netstat}_seq_show hejianet <hejianet@gmail.com> - 2016-09-22 07:40 +0200
  [RFC PATCH v3 6/7] ipv6: Remove useless parameter in __snmp6_fill_statsdev Jia He <hejianet@gmail.com> - 2016-09-09 08:40 +0200
  [RFC PATCH v3 5/7] proc: Reduce cache miss in xfrm_statistics_seq_show Jia He <hejianet@gmail.com> - 2016-09-09 08:40 +0200
  [RFC PATCH v3 1/7] net:snmp: Introduce generic batch interfaces for snmp_get_cpu_field{,64} Jia He <hejianet@gmail.com> - 2016-09-09 08:40 +0200
  [RFC PATCH v3 3/7] proc: Reduce cache miss in snmp6_seq_show Jia He <hejianet@gmail.com> - 2016-09-09 08:40 +0200
    Re: [RFC PATCH v3 3/7] proc: Reduce cache miss in snmp6_seq_show Marcelo <marcelo.leitner@gmail.com> - 2016-09-12 21:10 +0200
      Re: [RFC PATCH v3 3/7] proc: Reduce cache miss in snmp6_seq_show hejianet <hejianet@gmail.com> - 2016-09-14 05:20 +0200
  [RFC PATCH v3 7/7] net: Suppress the "Comparison to NULL could be written" warning Jia He <hejianet@gmail.com> - 2016-09-09 08:40 +0200

csiph-web