Re: [PATCH v2 2/8] sched: Extend scheduler's asym packing

From	Peter Zijlstra <peterz@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/8] sched: Extend scheduler's asym packing
Date	2016-09-08 20:30 +0200
Message-ID	<sfcff-S4-1@gated-at.bofh.it> (permalink)
References	<scHpf-70l-11@gated-at.bofh.it> <scHIC-79t-39@gated-at.bofh.it> <sf2zf-3eC-9@gated-at.bofh.it> <sfbVT-HP-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Sep 08, 2016 at 11:03:26AM -0700, Tim Chen wrote:
> On Thu, Sep 08, 2016 at 10:01:11AM +0200, Peter Zijlstra wrote:
> > On Thu, Sep 01, 2016 at 01:33:38PM -0700, Srinivas Pandruvada wrote:
> > > +++ b/kernel/sched/sched.h
> > > @@ -532,6 +532,17 @@ struct dl_rq {
> > >  
> > >  #ifdef CONFIG_SMP
> > >  
> > > +static inline bool sched_asym_prefer(int a, int b)
> > > +{
> > > +	return arch_asym_cpu_priority(a) > arch_asym_cpu_priority(b);
> > > +}
> > > +
> > > +/*
> > > + * Return lowest numbered cpu in the group as the most preferred cpu
> > > + * for ASYM_PACKING for default case.
> > > + */
> > > +#define group_priority_cpu(group) group->asym_prefer_cpu
> > > +
> > 
> > Both these are no longer used outside of sched/fair.c, and should
> > probably be moved there. Also the later has no reason for being a macro.
> 
> Peter,
> 
> The sched_asym_prefer is used in sched/core.c to set asym_prefer_cpu
> in a group. So we will still need the definition in sched.h.  I've removed
> the group_priority_cpu macro.

Ah indeed. Thanks!

Thread

[PATCH v2 0/8] Support Intel® Turbo Boost Max Technology 3.0 Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> - 2016-09-01 23:10 +0200
  [PATCH v2 4/8] sched, x86: use arch_update_cpu_topology to indicate x86 need sched domain rebuild Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> - 2016-09-01 23:10 +0200
  [PATCH v2 6/8] acpi: bus: Enable HWP CPPC objects Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> - 2016-09-01 23:20 +0200
  [PATCH v2 8/8] cpufreq: intel_pstate: Use CPPC to get max performance Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> - 2016-09-01 23:20 +0200
  [PATCH v2 3/8] x86, cpu: provide a function topology_num_packages to enumerate #packages Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> - 2016-09-01 23:20 +0200
  [PATCH v2 2/8] sched: Extend scheduler's asym packing Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> - 2016-09-01 23:30 +0200
    Re: [PATCH v2 2/8] sched: Extend scheduler's asym packing Peter Zijlstra <peterz@infradead.org> - 2016-09-08 10:10 +0200
      Re: [PATCH v2 2/8] sched: Extend scheduler's asym packing Tim Chen <tim.c.chen@linux.intel.com> - 2016-09-08 20:10 +0200
        Re: [PATCH v2 2/8] sched: Extend scheduler's asym packing Peter Zijlstra <peterz@infradead.org> - 2016-09-08 20:30 +0200
  Re: [PATCH v2 0/8] Support Intel® Turbo Boost Max Technology 3.0 Peter Zijlstra <peterz@infradead.org> - 2016-09-08 10:10 +0200

csiph-web