Re: [PATCH 1/7] pinctrl: amlogic: gxbb: add spifc pins

From	Kevin Hilman <khilman@baylibre.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/7] pinctrl: amlogic: gxbb: add spifc pins
Date	2016-09-08 20:10 +0200
Message-ID	<sfbVU-HP-21@gated-at.bofh.it> (permalink)
References	<seMNP-1pB-3@gated-at.bofh.it> <seMXw-1t1-51@gated-at.bofh.it>
Organization	BayLibre

Show all headers | View raw

Jerome Brunet <jbrunet@baylibre.com> writes:

> Add EE domains pins for the SPI flash controller
>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
>  drivers/pinctrl/meson/pinctrl-meson-gxbb.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>
> diff --git a/drivers/pinctrl/meson/pinctrl-meson-gxbb.c b/drivers/pinctrl/meson/pinctrl-meson-gxbb.c
> index cb4d6ad..802ad83 100644
> --- a/drivers/pinctrl/meson/pinctrl-meson-gxbb.c
> +++ b/drivers/pinctrl/meson/pinctrl-meson-gxbb.c
> @@ -156,6 +156,11 @@ static const unsigned int emmc_clk_pins[] = { PIN(BOOT_8, EE_OFF) };
>  static const unsigned int emmc_cmd_pins[] = { PIN(BOOT_10, EE_OFF) };
>  static const unsigned int emmc_ds_pins[] = { PIN(BOOT_15, EE_OFF) };
>  
> +static const unsigned int spifc_d_pins[]	= { PIN(BOOT_11, EE_OFF) };
> +static const unsigned int spifc_q_pins[]	= { PIN(BOOT_12, EE_OFF) };
> +static const unsigned int spifc_c_pins[]	= { PIN(BOOT_13, EE_OFF) };
> +static const unsigned int spifc_cs_pins[]	= { PIN(BOOT_15, EE_OFF) };

In the datasheet, these are called nor_* instead of spifc_*.  I'm trying
to keep the names here aligned with the names in the datasheet.  Please
rename to nor_*.

Thanks,

Kevin

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/7] ARM: amlogic: Add spifc support to Amlogic's GXBB family Jerome Brunet <jbrunet@baylibre.com> - 2016-09-07 17:30 +0200
  [PATCH 1/7] pinctrl: amlogic: gxbb: add spifc pins Jerome Brunet <jbrunet@baylibre.com> - 2016-09-07 17:30 +0200
    Re: [PATCH 1/7] pinctrl: amlogic: gxbb: add spifc pins Kevin Hilman <khilman@baylibre.com> - 2016-09-08 20:10 +0200

csiph-web