Re: [PATCH v2] gpio/gpiolib: Forbid irqchip default trigger if probed over DT

From	Marc Zyngier <marc.zyngier@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] gpio/gpiolib: Forbid irqchip default trigger if probed over DT
Date	2016-09-08 19:20 +0200
Message-ID	<sfb9v-bn-11@gated-at.bofh.it> (permalink)
References	<seGfn-5H3-9@gated-at.bofh.it> <seTmi-5SM-19@gated-at.bofh.it>
Organization	ARM Ltd

Show all headers | View raw

On 07/09/16 23:18, Linus Walleij wrote:
> On Wed, Sep 7, 2016 at 10:12 AM, Marc Zyngier <marc.zyngier@arm.com> wrote:
> 
>> Using a default trigger is a bad idea if using DT to configure
>> interrupts, as the device's interrupt specifier will always contain
>> the trigger configuration.
>>
>> Let's warn about that particular situation, and revert to not
>> having a default. Hopefully, the couple of drivers still using
>> this feature will quickly be fixed.
>>
>> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
>> ---
>> Send the tested patch this time around...
> 
> I got it the first time, don't worry :D

Errrr, the first one didn't even compile (I'm such a moron sometimes).
Please apply this one instead, which has actually been compile-tested.

Sorry for the noise.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] gpio/gpiolib: Forbid irqchip default trigger if probed over DT Marc Zyngier <marc.zyngier@arm.com> - 2016-09-07 10:20 +0200
  Re: [PATCH v2] gpio/gpiolib: Forbid irqchip default trigger if probed  over DT Linus Walleij <linus.walleij@linaro.org> - 2016-09-08 00:20 +0200
    Re: [PATCH v2] gpio/gpiolib: Forbid irqchip default trigger if probed  over DT Marc Zyngier <marc.zyngier@arm.com> - 2016-09-08 19:20 +0200

csiph-web