Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1480512

Re: [PATCH] Add additional Intel CPU models to crystal_khz whitelist

Show all headers | View raw

On Fri, 9 Sep 2016, Prarit Bhargava wrote:

> In commit aa297292d708 ("x86/tsc: Enumerate SKL cpu_khz and tsc_khz via

You cite a commit here, which is nice. If you look at the commit message
then you will notice that _before_ the sentence describing the commit there
is a prefix, which denotes the subsystem to which this patch applies. But
you insist on sending patches w/o a prefix.

Can you please stop this? It's annoying because I have to figure out where
the patch belongs to and have to edit the subject line before applying the
patch.


> @@ -688,11 +688,19 @@ unsigned long native_calibrate_tsc(void)
>  		switch (boot_cpu_data.x86_model) {
>  		case 0x4E:	/* SKL */
>  		case 0x5E:	/* SKL */
> +		case 0x8E:	/* KBL */
> +		case 0x9E:	/* KBL */

asm/intel-family.h provides proper defines for this. And before you add
those, please make a seperate patch which converts the existing hex
constants to the defines.

Thanks,

	tglx

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Add additional Intel CPU models to crystal_khz whitelist Prarit Bhargava <prarit@redhat.com> - 2016-09-09 17:20 +0200
  Re: [PATCH] Add additional Intel CPU models to crystal_khz  whitelist Thomas Gleixner <tglx@linutronix.de> - 2016-09-10 08:40 +0200

csiph-web