Re: [PATCH 4/8] ARM: dts: bcm283x: Add a new EMMC pin group from the downstream tree.

From	Eric Anholt <eric@anholt.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/8] ARM: dts: bcm283x: Add a new EMMC pin group from the downstream tree.
Date	2016-09-09 23:30 +0200
Message-ID	<sfBwZ-8ao-5@gated-at.bofh.it> (permalink)
References	<seIqS-6Zc-7@gated-at.bofh.it> <seIqS-6Zc-27@gated-at.bofh.it> <sePC2-3ed-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Stefan Wahren <stefan.wahren@i2se.com> writes:

>> Gerd Hoffmann <kraxel@redhat.com> hat am 7. September 2016 um 12:31
>> geschrieben:
>> 
>> 
>> From: Eric Anholt <eric@anholt.net>
>> 
>> This will be used for having EMMC (sdhci-bcm2835.c) drive the
>> wireless.
>
> sdhci-bcm2835.c has been replaced by sdhci-iproc.c
>
>> 
>> Signed-off-by: Eric Anholt <eric@anholt.net>
>> ---
>>  arch/arm/boot/dts/bcm283x.dtsi | 5 +++++
>>  1 file changed, 5 insertions(+)
>> 
>> diff --git a/arch/arm/boot/dts/bcm283x.dtsi b/arch/arm/boot/dts/bcm283x.dtsi
>> index 062d09db..b6b1950 100644
>> --- a/arch/arm/boot/dts/bcm283x.dtsi
>> +++ b/arch/arm/boot/dts/bcm283x.dtsi
>> @@ -257,6 +257,11 @@
>>  				brcm,pins = <32 33>;
>>  				brcm,function = <BCM2835_FSEL_ALT3>;
>>  			};
>> +			emmc_gpio34: emmc_gpio34 {
>> +				brcm,pins = <34 35 36 37 38 39>;
>> +				brcm,function = <BCM2835_FSEL_ALT3>;
>> +				brcm,pull = <0 2 2 2 2 2>;
>
> How about adding pull defines to include/dt-bindings/pinctrl/bcm2835.h?

A fine idea, but it should not be a requirement for this series.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 4/8] ARM: dts: bcm283x: Add a new EMMC pin group from the downstream tree. Gerd Hoffmann <kraxel@redhat.com> - 2016-09-07 12:40 +0200
  Re: [PATCH 4/8] ARM: dts: bcm283x: Add a new EMMC pin group from  the downstream tree. Stefan Wahren <stefan.wahren@i2se.com> - 2016-09-07 20:20 +0200
    Re: [PATCH 4/8] ARM: dts: bcm283x: Add a new EMMC pin group from  the downstream tree. Gerd Hoffmann <kraxel@redhat.com> - 2016-09-08 09:50 +0200
      Re: [PATCH 4/8] ARM: dts: bcm283x: Add a new EMMC pin group from the  downstream tree. Stefan Wahren <stefan.wahren@i2se.com> - 2016-09-08 14:10 +0200
        Re: [PATCH 4/8] ARM: dts: bcm283x: Add a new EMMC pin group from  the downstream tree. Gerd Hoffmann <kraxel@redhat.com> - 2016-09-09 10:30 +0200
          Re: [PATCH 4/8] ARM: dts: bcm283x: Add a new EMMC pin group from  the downstream tree. Gerd Hoffmann <kraxel@redhat.com> - 2016-09-09 10:50 +0200
      Re: [PATCH 4/8] ARM: dts: bcm283x: Add a new EMMC pin group from the  downstream tree. Scott Branden <scott.branden@broadcom.com> - 2016-09-08 22:00 +0200
        Re: [PATCH 4/8] ARM: dts: bcm283x: Add a new EMMC pin group from the  downstream tree. Stefan Wahren <stefan.wahren@i2se.com> - 2016-09-09 09:00 +0200
          Re: [PATCH 4/8] ARM: dts: bcm283x: Add a new EMMC pin group from the  downstream tree. Scott Branden <scott.branden@broadcom.com> - 2016-09-09 18:40 +0200
    Re: [PATCH 4/8] ARM: dts: bcm283x: Add a new EMMC pin group from the downstream tree. Eric Anholt <eric@anholt.net> - 2016-09-09 23:30 +0200

csiph-web