Re: [v2] musb: omap2430: do not assume balanced enable()/disable()

From	Tony Lindgren <tony@atomide.com>
Newsgroups	linux.kernel
Subject	Re: [v2] musb: omap2430: do not assume balanced enable()/disable()
Date	2016-09-09 23:00 +0200
Message-ID	<sfB3X-7LQ-3@gated-at.bofh.it> (permalink)
References	<s27wJ-4Vz-25@gated-at.bofh.it> <sfzER-6Yg-13@gated-at.bofh.it> <sfAhA-7rj-17@gated-at.bofh.it> <sfAAV-7Cd-5@gated-at.bofh.it> <sfAUh-7Iw-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Andreas Kemnade <andreas@kemnade.info> [160909 13:40]:
> On Fri, 09 Sep 2016 23:21:50 +0300
> Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:
> > 
> > How exactly is it worse breaking runtime PM than breaking USB gadget 
> > completely ? :-)
> > 
> Does it still break with my phy-twl4030 fixes? At least on gta04,
> they fix real problems and hide the musb problem I tried to fix with
> this patch.
> https://patchwork.kernel.org/patch/9292097/
> https://patchwork.kernel.org/patch/9298447/

Andreas, it's a different USB PHY on pandaboard, that's using
phy-twl6030-usb.c. Probably similar issue.

> > The issue here is that the .disable() platform operation is called by
> > musb with the PHY already powered off, leading to the PHY power
> > reference count becoming negative. The next call to the .enable()
> > operation restores the reference count to 0 without enabling the PHY.
> > 
> > Feel free to send me a better fix and I will test it.
> > 
> The patch has to be reworked on top of the patch series:
> Implement PM runtime for musb-core based on session bit

Yeah that leaves out all most of the trickery with the glue
specific PM runtime tinkering so tracking down any remaining
unbalanced calls should be easier :)

But that's for v4.9, let's see what's the minimal fix for v4.8.

Regards,

Tony

Thread

Re: [v2] musb: omap2430: do not assume balanced enable()/disable() Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2016-09-09 21:30 +0200
  Re: [v2] musb: omap2430: do not assume balanced enable()/disable() Tony Lindgren <tony@atomide.com> - 2016-09-09 22:10 +0200
    Re: [v2] musb: omap2430: do not assume balanced enable()/disable() Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2016-09-09 22:30 +0200
      Re: [v2] musb: omap2430: do not assume balanced enable()/disable() Andreas Kemnade <andreas@kemnade.info> - 2016-09-09 22:50 +0200
        Re: [v2] musb: omap2430: do not assume balanced enable()/disable() Tony Lindgren <tony@atomide.com> - 2016-09-09 23:00 +0200
      Re: [v2] musb: omap2430: do not assume balanced enable()/disable() Tony Lindgren <tony@atomide.com> - 2016-09-09 23:00 +0200
        Re: [v2] musb: omap2430: do not assume balanced enable()/disable() Andreas Kemnade <andreas@kemnade.info> - 2016-09-09 23:30 +0200
          Re: [v2] musb: omap2430: do not assume balanced enable()/disable() Tony Lindgren <tony@atomide.com> - 2016-09-09 23:40 +0200
            Re: [v2] musb: omap2430: do not assume balanced enable()/disable() Tony Lindgren <tony@atomide.com> - 2016-09-10 01:50 +0200
              Re: [v2] musb: omap2430: do not assume balanced enable()/disable() Andreas Kemnade <andreas@kemnade.info> - 2016-09-10 13:30 +0200
                Re: [v2] musb: omap2430: do not assume balanced enable()/disable() Tony Lindgren <tony@atomide.com> - 2016-09-10 15:10 +0200
                Re: [v2] musb: omap2430: do not assume balanced enable()/disable() Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2016-09-11 11:10 +0200
                Re: [v2] musb: omap2430: do not assume balanced enable()/disable() Tony Lindgren <tony@atomide.com> - 2016-09-12 16:40 +0200

csiph-web