Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1480305

Re: [GIT PULL] overlayfs fix for 4.8-rc5

Show all headers | View raw

On Fri, Sep 9, 2016 at 9:58 PM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
> On Fri, Sep 9, 2016 at 12:37 PM, Miklos Szeredi <miklos@szeredi.hu> wrote:
>>
>> This fixes a regression caused by the last pull request.
>
> So why are you checking error numbers one by one?
>
> Why is an error not just always an error?

The issue is that not all errors should result in failure.

That code tries to remove ACL from a directory, and there are several cases:

1) success: that's good obviously
2) error: no ACL was found: that's also good
3) error: ACL's are not supported by the filesystem: this is also good
4) error: ACL was there but we failed to remove it for some other
reason: this is not good

The patch adds handling of case 3.

Thanks,
Miklos

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[GIT PULL] overlayfs fix for 4.8-rc5 Miklos Szeredi <miklos@szeredi.hu> - 2016-09-09 21:40 +0200
  Re: [GIT PULL] overlayfs fix for 4.8-rc5 Linus Torvalds <torvalds@linux-foundation.org> - 2016-09-09 22:00 +0200
    Re: [GIT PULL] overlayfs fix for 4.8-rc5 Miklos Szeredi <miklos@szeredi.hu> - 2016-09-09 22:10 +0200
      Re: [GIT PULL] overlayfs fix for 4.8-rc5 Linus Torvalds <torvalds@linux-foundation.org> - 2016-09-09 22:40 +0200
        Re: [GIT PULL] overlayfs fix for 4.8-rc5 Miklos Szeredi <miklos@szeredi.hu> - 2016-09-09 23:20 +0200
          Re: [GIT PULL] overlayfs fix for 4.8-rc5 Linus Torvalds <torvalds@linux-foundation.org> - 2016-09-09 23:50 +0200

csiph-web