Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1479155

Re: A potential bug in drivers/usb/gadget/udc/m66592-udc.ko

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

Pavel Andrianov <andrianov@ispras.ru> writes:
> Hi!
>
> There is a potential bug in drivers/usb/gadget/udc/m66592-udc.ko.
> In m66592_probe interrupts are requested at line 1612. After that 
> initialization of common resources is continued. For example, in
>
> -> usb_add_gadget_udc (line 1678)
>    -> usb_add_gadget_udc_release
>      -> udc_bind_to_driver
>        -> usb_gadget_udc_start
>          -> m66592_udc_start
>
> m66592->driver is set. In interrupt handler the data is used, thus if 
> interrupt comes before udc_start is executed, null pointer dereference 
> occurs.
> Should the call of request_irq be after complete initialization?

interrupts will only fire after we connect data pullups, that's done by
->pullup() method waaaaaaaay later ;-)

-- 
balbi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

A potential bug in drivers/usb/gadget/udc/m66592-udc.ko Pavel Andrianov <andrianov@ispras.ru> - 2016-09-08 11:20 +0200
  Re: A potential bug in drivers/usb/gadget/udc/m66592-udc.ko Felipe Balbi <felipe.balbi@linux.intel.com> - 2016-09-08 14:10 +0200

csiph-web