Re: [PATCH v5 6/6] gpio: pca953x: make the define names consistent

From	Bartosz Golaszewski <bgolaszewski@baylibre.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 6/6] gpio: pca953x: make the define names consistent
Date	2016-09-08 14:30 +0200
Message-ID	<sf6CS-5Lv-19@gated-at.bofh.it> (permalink)
References	<sf545-4HL-3@gated-at.bofh.it> <sf545-4HL-1@gated-at.bofh.it> <sf6CR-5Lv-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

2016-09-08 14:27 GMT+02:00 Andy Shevchenko <andriy.shevchenko@linux.intel.com>:
> On Thu, 2016-09-08 at 12:48 +0200, Bartosz Golaszewski wrote:
>> The register offset defines for the pca953x and pca957x expander
>> families should have the same names to better reflect their similar
>> purposes.
>
>
>
>
>>       chip->regs = &pca957x_regs;
>>
>> -     ret = pca953x_read_regs(chip, PCA957X_OUT, chip->reg_output);
>> +     ret = pca953x_read_regs(chip, PCA957X_OUTPUT, chip-
>> >reg_output);
>>       if (ret)
>>               goto out;
>> -     ret = pca953x_read_regs(chip, PCA957X_CFG, chip-
>> >reg_direction);
>> +     ret = pca953x_read_regs(chip, PCA957X_DIRECTION, chip-
>> >reg_direction);
>
> Bu we may use chip->regs->direction here, right? And output before.
>

Yes, though it should go into patch 1/6.

Thanks,
Bartosz

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v5 6/6] gpio: pca953x: make the define names consistent Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2016-09-08 12:50 +0200
  Re: [PATCH v5 6/6] gpio: pca953x: make the define names consistent Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-09-08 14:30 +0200
    Re: [PATCH v5 6/6] gpio: pca953x: make the define names consistent Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-09-08 14:30 +0200
      Re: [PATCH v5 6/6] gpio: pca953x: make the define names consistent Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2016-09-08 16:20 +0200
    Re: [PATCH v5 6/6] gpio: pca953x: make the define names consistent Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2016-09-08 14:30 +0200

csiph-web