Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1478944

Re: [PATCH v4 4/8] dts: sun8i-h3: move uart1 pinmux/peripheral assocation to DSTI

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Thu, Sep 08, 2016 at 10:02:13AM +0200, Jorik Jonker wrote:
> Maxime, Chen-Yu: thanks for taking the effort to go through my patches
> again!
> 
> On Thu, Sep 08, 2016 at 08:23:17AM +0200, Maxime Ripard wrote:
> >On Wed, Sep 07, 2016 at 09:58:57AM +0200, jorik@kippendief.biz wrote:
> >>From: Jorik Jonker <jorik@kippendief.biz>
> >>
> >>Users using this UART without RTS/CTS should override the association in
> >>their board specific DTS. All (1) board using this UART uses RTS/CTS, so
> >>this breaks nothing.
> >
> >Using RTS / CTS is very rare among the boards. Forcing it down the
> >throat of every user doesn't seem like the right thing to do.
> 
> So, I'm going for a v5, with these changes:
> - rename uart0_pins to uart0_pa_pins (as there could be a pf)
> - associate uart0_pa_pins with uart0 on all H3 board DTS files

Please don't. We use that naming scheme everywhere else. Plus, nothing
prevents any one from using one PF pin and one PA pin.

> - put rts/cts in seperate pinmux sets for uart1 (2,3: see below)
> - associate rx/tx for uart1-3 in H3 DTSI (this is the only option)

I'm still a bit skeptical about this. This wouldn't be in any way
consistant. I prefer to have something consistant and a bit duplicated
over something without any duplication but that confuses everyone
about what should be placed where.

> - associate UART1 rts/cts as pinctrl-1 in sun8i-h3-bananapi-m2-plus
>  (to prevent breakage for existing users)

You can also set it in pinctrl-0.

> I am a bit in doubt if I should include pinmux definitions for the following
> things, as Chen-Yu said to only include stuff that is actually used in a
> board:
> 
> - uart0_pf_pins, since there is no board using it
> - uart{2,3}_rts_cts, as I agree RTS/CTS is a bit exotic

Don't

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 0/8] dts: sun8i-h3: complete UART I2C definitions for H3 jorik@kippendief.biz - 2016-09-07 10:00 +0200
  [PATCH v4 4/8] dts: sun8i-h3: move uart1 pinmux/peripheral assocation to DSTI jorik@kippendief.biz - 2016-09-07 10:10 +0200
    Re: [PATCH v4 4/8] dts: sun8i-h3: move uart1 pinmux/peripheral  assocation to DSTI Chen-Yu Tsai <wens@csie.org> - 2016-09-07 11:00 +0200
    Re: [PATCH v4 4/8] dts: sun8i-h3: move uart1 pinmux/peripheral  assocation to DSTI Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-08 08:30 +0200
      Re: [PATCH v4 4/8] dts: sun8i-h3: move uart1 pinmux/peripheral  assocation to DSTI Jorik Jonker <jorik@kippendief.biz> - 2016-09-08 10:10 +0200
        Re: [PATCH v4 4/8] dts: sun8i-h3: move uart1 pinmux/peripheral  assocation to DSTI Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-08 11:10 +0200
          Re: [PATCH v4 4/8] dts: sun8i-h3: move uart1 pinmux/peripheral  assocation to DSTI Jorik Jonker <jorik@kippendief.biz> - 2016-09-08 12:00 +0200
  [PATCH v4 3/8] dts: sun8i-h3: move uart0 pinmux/peripheral assocation to DSTI jorik@kippendief.biz - 2016-09-07 10:10 +0200
    Re: [PATCH v4 3/8] dts: sun8i-h3: move uart0 pinmux/peripheral  assocation to DSTI Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-08 08:30 +0200
  [PATCH v4 8/8] dts: sun8i-h3: add I2C0-2 peripherals to H3 SOC jorik@kippendief.biz - 2016-09-07 10:10 +0200
  [PATCH v4 6/8] dts: sun8i-h3: associate pinmux/peripherals for UART2-3 jorik@kippendief.biz - 2016-09-07 10:10 +0200
  [PATCH v4 7/8] dts: sun8i-h3: add pinmux definitions for I2C0-2 jorik@kippendief.biz - 2016-09-07 10:10 +0200
  [PATCH v4 5/8] dts: sun8i-h3: add pinmux definitions for UART2-3 jorik@kippendief.biz - 2016-09-07 10:10 +0200

csiph-web