Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1478868

Re: [PATCH 2/2] cpu hotplug, add CONFIG_PERMANENT_CPU_TOPOLOGY

Show all headers | View raw

On Wed, Sep 07, 2016 at 07:44:17AM -0400, Prarit Bhargava wrote:
> The information in /sys/devices/system/cpu/cpuX/topology
> directory is useful for userspace monitoring applications and in-tree
> utilities like cpupower & turbostat.
> 
> When down'ing a CPU the /sys/devices/system/cpu/cpuX/topology directory is
> removed during the CPU_DEAD hotplug callback in the kernel.  The problem
> with this model is that the CPU has not been physically removed and the
> data in the topology directory is still valid and the cpu's location is
> now lost to userspace.
> 
> This patch adds CONFIG_PERMANENT_CPU_TOPOLOGY, and is Y by default for
> x86, an N for all other arches.  When enabled the kernel is modified so
> that the topology directory is added to the core cpu sysfs files so that
> the topology directory exists while the CPU is physically present.  When
> disabled, the behavior of the current kernel is maintained (that is, the
> topology directory is removed on a soft down and added on an soft up).
> Adding CONFIG_PERMANENT_CPU_TOPOLOGY may require additional architecture
> so that the cpumask data the CPU's topology is not cleared during a CPU
> down.

So how do you physically remove things and how does the information then
get removed?

Also, why is that an x86 only feature?

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] cpu hotplug, keep topology directory after soft remove event Prarit Bhargava <prarit@redhat.com> - 2016-09-07 13:50 +0200
  [PATCH 1/2] drivers/base: Combine topology.c and cpu.c Prarit Bhargava <prarit@redhat.com> - 2016-09-07 13:50 +0200
  [PATCH 2/2] cpu hotplug, add CONFIG_PERMANENT_CPU_TOPOLOGY Prarit Bhargava <prarit@redhat.com> - 2016-09-07 13:50 +0200
    Re: [PATCH 2/2] cpu hotplug, add CONFIG_PERMANENT_CPU_TOPOLOGY Peter Zijlstra <peterz@infradead.org> - 2016-09-08 09:50 +0200
      Re: [PATCH 2/2] cpu hotplug, add CONFIG_PERMANENT_CPU_TOPOLOGY Prarit Bhargava <prarit@redhat.com> - 2016-09-08 15:50 +0200

csiph-web