Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1478802

Re: [PATCH, net-next] perf, bpf: fix conditional call to bpf_overflow_handler

Show all headers | View raw

* Alexei Starovoitov <alexei.starovoitov@gmail.com> wrote:

> On Tue, Sep 06, 2016 at 03:10:22PM +0200, Arnd Bergmann wrote:
> > The newly added bpf_overflow_handler function is only built of both
> > CONFIG_EVENT_TRACING and CONFIG_BPF_SYSCALL are enabled, but the caller
> > only checks the latter:
> > 
> > kernel/events/core.c: In function 'perf_event_alloc':
> > kernel/events/core.c:9106:27: error: 'bpf_overflow_handler' undeclared (first use in this function)
> > 
> > This changes the caller so we also skip this call if CONFIG_EVENT_TRACING
> > is disabled entirely.
> > 
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Fixes: aa6a5f3cb2b2 ("perf, bpf: add perf events core support for BPF_PROG_TYPE_PERF_EVENT programs")
> > ---
> >  kernel/events/core.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > I'm not entirely sure if this is the correct solution, please check before applying
> 
> Acked-by: Alexei Starovoitov <ast@kernel.org>
> 
> Thanks for the fix. Just saw build bot complaining last night and
> by the morning your fix is already here. Thanks!

Guys, this is the first time I saw this patch (and presumably there's some other 
patch as well?) - could you please submit it properly for review and get an 
Acked-by from one of the perf maintainers before appying it?

Thanks,

	Ingo

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH, net-next] perf, bpf: fix conditional call to bpf_overflow_handler Arnd Bergmann <arnd@arndb.de> - 2016-09-06 15:20 +0200
  Re: [PATCH, net-next] perf, bpf: fix conditional call to  bpf_overflow_handler Alexei Starovoitov <alexei.starovoitov@gmail.com> - 2016-09-06 17:40 +0200
    Re: [PATCH, net-next] perf, bpf: fix conditional call to  bpf_overflow_handler Ingo Molnar <mingo@kernel.org> - 2016-09-08 08:40 +0200
      Re: [PATCH, net-next] perf, bpf: fix conditional call to  bpf_overflow_handler Peter Zijlstra <peterz@infradead.org> - 2016-09-08 09:00 +0200
        Re: [PATCH, net-next] perf, bpf: fix conditional call to  bpf_overflow_handler Ingo Molnar <mingo@kernel.org> - 2016-09-08 09:10 +0200
          Re: [PATCH, net-next] perf, bpf: fix conditional call to bpf_overflow_handler Daniel Borkmann <daniel@iogearbox.net> - 2016-09-08 10:10 +0200
            Re: [PATCH, net-next] perf, bpf: fix conditional call to  bpf_overflow_handler Ingo Molnar <mingo@kernel.org> - 2016-09-08 11:50 +0200

csiph-web