Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1477775

Re: [PATCH v6 2/3] usb: musb: da8xx: Use devm in probe

Show all headers | View raw

Hi,

On Mon, Sep 05, 2016 at 03:00:32PM -0500, David Lechner wrote:
> Simplify things a bit by using devm functions where possible.
> 
> Signed-off-by: David Lechner <david@lechnology.com>
> ---
>  drivers/usb/musb/da8xx.c | 19 +++++--------------
>  1 file changed, 5 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/usb/musb/da8xx.c b/drivers/usb/musb/da8xx.c
> index b03d3b8..0c1997c 100644
> --- a/drivers/usb/musb/da8xx.c
> +++ b/drivers/usb/musb/da8xx.c
> @@ -490,20 +490,18 @@ static int da8xx_probe(struct platform_device *pdev)
>  	struct da8xx_glue		*glue;
>  	struct platform_device_info	pinfo;
>  	struct clk			*clk;
> +	int				ret;
>  
> -	int				ret = -ENOMEM;
> -
> -	glue = kzalloc(sizeof(*glue), GFP_KERNEL);
> +	glue = devm_kzalloc(&pdev->dev, sizeof(*glue), GFP_KERNEL);
>  	if (!glue) {
>  		dev_err(&pdev->dev, "failed to allocate glue context\n");

Greg's usb-next already has a patch which drops this line. You might
have to rebase this patch, so that it can go to v4.9-rc1.

Thanks,
-Bin.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v6 0/3] da8xx USB PHY platform devices and clocks David Lechner <david@lechnology.com> - 2016-09-05 22:10 +0200
  [PATCH v6 3/3] usb: musb: da8xx: Remove mach code David Lechner <david@lechnology.com> - 2016-09-05 22:10 +0200
  [PATCH v6 2/3] usb: musb: da8xx: Use devm in probe David Lechner <david@lechnology.com> - 2016-09-05 22:10 +0200
    Re: [PATCH v6 2/3] usb: musb: da8xx: Use devm in probe Bin Liu <b-liu@ti.com> - 2016-09-06 21:20 +0200
  Re: [PATCH v6 0/3] da8xx USB PHY platform devices and clocks Bin Liu <b-liu@ti.com> - 2016-09-06 21:30 +0200

csiph-web