Re: [PATCH] ptp: ixp46x: remove NO_IRQ handling

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ptp: ixp46x: remove NO_IRQ handling
Date	2016-09-06 21:20 +0200
Message-ID	<seu4x-655-1@gated-at.bofh.it> (permalink)
References	<sepxT-3ab-3@gated-at.bofh.it> <serzI-4pL-35@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tuesday, September 6, 2016 6:39:10 PM CEST Richard Cochran wrote:
> On Tue, Sep 06, 2016 at 04:28:30PM +0200, Arnd Bergmann wrote:
> > gpio_to_irq does not return NO_IRQ but instead returns a negative
> > error code on failure. Returning NO_IRQ from the function has no
> > negative effects as we only compare the result to the expected
> > interrupt number, but it's better to return a proper failure
> > code for consistency, and we should remove NO_IRQ from the kernel
> > entirely.
> > 
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 
> Acked-by: Richard Cochran <richardcochran@gmail.com>

Thanks!

I just realized that the randconfig builder had not picked up this
one and there was a typo. I'll send a replacement patch with your
Ack added in.

	Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ptp: ixp46x: remove NO_IRQ handling Arnd Bergmann <arnd@arndb.de> - 2016-09-06 16:30 +0200
  Re: [PATCH] ptp: ixp46x: remove NO_IRQ handling Richard Cochran <richardcochran@gmail.com> - 2016-09-06 18:40 +0200
    Re: [PATCH] ptp: ixp46x: remove NO_IRQ handling Arnd Bergmann <arnd@arndb.de> - 2016-09-06 21:20 +0200

csiph-web