Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1477588

Re: [PATCH v2 2/7] clk: sunxi-ng: div: Allow to set a maximum

Show all headers | View raw

On Tue, Sep 6, 2016 at 8:18 PM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> Some dividers might have a maximum value that is lower than the width of
> the register.
>
> Add a field to _ccu_div to handle those case properly. If the field is set
> to 0, the code will assume that the maximum value is the maximum one that
> can be used with the field register width.

This is a bit confusing. What is the maximum referring to? The raw value
in the register? Or the actual divider?

Personally I'd go with the maximum valid value of the register. You
could get rid of the special power-of-2 handling code you added.

Either way I think the message and the field name should be more explicit.

>
> Otherwise, we'll use whatever value has been set.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>

[...]

The code looks correct.


Regards
ChenYu

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/7] clk: sunxi-ng: Introduce support for A23 and A33 CCUs Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-06 14:20 +0200
  [PATCH v2 1/7] clk: sunxi-ng: div: Add mux table macros Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-06 14:20 +0200
  [PATCH v2 7/7] ARM: sun8i: Convert the A23 and A33 to the CCU Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-06 14:20 +0200
    Re: [PATCH v2 7/7] ARM: sun8i: Convert the A23 and A33 to the CCU Chen-Yu Tsai <wens@csie.org> - 2016-09-06 16:10 +0200
      Re: [PATCH v2 7/7] ARM: sun8i: Convert the A23 and A33 to the CCU Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-07 22:50 +0200
  [PATCH v2 5/7] clk: sunxi-ng: Add A33 CCU support Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-06 14:20 +0200
    Re: [PATCH v2 5/7] clk: sunxi-ng: Add A33 CCU support Chen-Yu Tsai <wens@csie.org> - 2016-09-07 09:10 +0200
  [PATCH v2 2/7] clk: sunxi-ng: div: Allow to set a maximum Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-06 14:30 +0200
    Re: [PATCH v2 2/7] clk: sunxi-ng: div: Allow to set a maximum Chen-Yu Tsai <wens@csie.org> - 2016-09-06 18:30 +0200
      Re: [PATCH v2 2/7] clk: sunxi-ng: div: Allow to set a maximum Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-08 11:00 +0200
  [PATCH v2 3/7] clk: sunxi-ng: mux: Add mux table macro Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-06 14:30 +0200
  [PATCH v2 4/7] clk: sunxi-ng: Add N-class clocks support Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-09-06 14:30 +0200
    Re: [PATCH v2 4/7] clk: sunxi-ng: Add N-class clocks support Chen-Yu Tsai <wens@csie.org> - 2016-09-07 08:50 +0200

csiph-web