[PATCH 4/5] mm: fix cache mode of dax pmd mappings

From	Dan Williams <dan.j.williams@intel.com>
Newsgroups	linux.kernel
Subject	[PATCH 4/5] mm: fix cache mode of dax pmd mappings
Date	2016-09-06 19:00 +0200
Message-ID	<serT3-4wT-5@gated-at.bofh.it> (permalink)
References	<serT3-4wT-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

track_pfn_insert() is marking dax mappings as uncacheable.

It is used to keep mappings attributes consistent across a remapped range.
However, since dax regions are never registered via track_pfn_remap(), the
caching mode lookup for dax pfns always returns _PAGE_CACHE_MODE_UC.  We do not
use track_pfn_insert() in the dax-pte path, and we always want to use the
pgprot of the vma itself, so drop this call.

Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: Matthew Wilcox <mawilcox@microsoft.com>
Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Nilesh Choudhury <nilesh.choudhury@oracle.com>
Reported-by: Kai Zhang <kai.ka.zhang@oracle.com>
Reported-by: Toshi Kani <toshi.kani@hpe.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
 mm/huge_memory.c |    2 --
 1 file changed, 2 deletions(-)

diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index a6abd76baa72..338eff05c77a 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -676,8 +676,6 @@ int vmf_insert_pfn_pmd(struct vm_area_struct *vma, unsigned long addr,
 
 	if (addr < vma->vm_start || addr >= vma->vm_end)
 		return VM_FAULT_SIGBUS;
-	if (track_pfn_insert(vma, &pgprot, pfn))
-		return VM_FAULT_SIGBUS;
 	insert_pfn_pmd(vma, addr, pmd, pfn, pgprot, write);
 	return VM_FAULT_NOPAGE;
 }

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 4/5] mm: fix cache mode of dax pmd mappings Dan Williams <dan.j.williams@intel.com> - 2016-09-06 19:00 +0200
  Re: [PATCH 4/5] mm: fix cache mode of dax pmd mappings Dan Williams <dan.j.williams@intel.com> - 2016-09-06 19:40 +0200
  RE: [PATCH 4/5] mm: fix cache mode of dax pmd mappings Matthew Wilcox <mawilcox@microsoft.com> - 2016-09-06 20:00 +0200
  Re: [PATCH 4/5] mm: fix cache mode of dax pmd mappings Andrew Morton <akpm@linux-foundation.org> - 2016-09-06 22:20 +0200
    Re: [PATCH 4/5] mm: fix cache mode of dax pmd mappings Dan Williams <dan.j.williams@intel.com> - 2016-09-07 00:00 +0200
      Re: [PATCH 4/5] mm: fix cache mode of dax pmd mappings "Kani, Toshimitsu" <toshi.kani@hpe.com> - 2016-09-07 21:40 +0200
        Re: [PATCH 4/5] mm: fix cache mode of dax pmd mappings Dan Williams <dan.j.williams@intel.com> - 2016-09-07 21:50 +0200

csiph-web