[PATCH 13/15] hisi_sas: remove init_id_frame_v1_hw()

Path	csiph.com!1.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!newsfeed.fsmpi.rwth-aachen.de!newsfeed.straub-nv.de!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	John Garry <john.garry@huawei.com>
Newsgroups	linux.kernel
Subject	[PATCH 13/15] hisi_sas: remove init_id_frame_v1_hw()
Date	Tue, 06 Sep 2016 17:30:03 +0200
Message-ID	<seqtZ-3JB-89@gated-at.bofh.it> (permalink)
References	<seqtX-3JB-13@gated-at.bofh.it>
X-Original-To	<jejb@linux.vnet.ibm.com>, <martin.petersen@oracle.com>
X-Mailer	git-send-email 1.9.1
MIME-Version	1.0
Content-Type	text/plain
X-Originating-IP	[10.67.212.75]
X-Cfilter-Loop	Reflected
X-Mirapoint-Virus-Rapid-Raw	score=unknown(0), refid=str=0001.0A020206.57CEDF8A.009C,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-ID	b59ad61022e502e35110b8d43cc15c64
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	46
Organization	linux.* mail to news gateway
X-Original-Cc	<linuxarm@huawei.com>, <zhangfei.gao@linaro.org>, <xuwei5@hisilicon.com>, <john.garry2@mail.dcu.ie>, <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>, John Garry <john.garry@huawei.com>, "Xiang Chen" <chenxiang66@hisilicon.com>
X-Original-Date	Tue, 6 Sep 2016 23:36:23 +0800
X-Original-Message-ID	<1473176185-217808-14-git-send-email-john.garry@huawei.com>
X-Original-References	<1473176185-217808-1-git-send-email-john.garry@huawei.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1477536

Show key headers only | View raw

Function config_id_frame_v1_hw() is called twice for
each PHY during initialisation, which is unneeded.

So remove init_id_frame_v1_hw(), which only calls
config_id_frame_v1_hw().

We will keep the call to config_id_frame_v1_hw()
in start_phy_v1_hw() since it will be used for
PHY reset functions.

Signed-off-by: John Garry <john.garry@huawei.com>
Signed-off-by: Xiang Chen <chenxiang66@hisilicon.com>
---
 drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
index c030df0..c0ac49d 100644
--- a/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
+++ b/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
@@ -501,14 +501,6 @@ static void config_id_frame_v1_hw(struct hisi_hba *hisi_hba, int phy_no)
 			__swab32(identify_buffer[5]));
 }
 
-static void init_id_frame_v1_hw(struct hisi_hba *hisi_hba)
-{
-	int i;
-
-	for (i = 0; i < hisi_hba->n_phy; i++)
-		config_id_frame_v1_hw(hisi_hba, i);
-}
-
 static void setup_itct_v1_hw(struct hisi_hba *hisi_hba,
 			     struct hisi_sas_device *sas_dev)
 {
@@ -774,8 +766,6 @@ static int hw_init_v1_hw(struct hisi_hba *hisi_hba)
 	msleep(100);
 	init_reg_v1_hw(hisi_hba);
 
-	init_id_frame_v1_hw(hisi_hba);
-
 	return 0;
 }
 
-- 
1.9.1

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 13/15] hisi_sas: remove init_id_frame_v1_hw() John Garry <john.garry@huawei.com> - 2016-09-06 17:30 +0200

csiph-web