Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1477500
| From | Jan Kara <jack@suse.cz> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] jbd2: add jbd2_journal_init() helper |
| Date | 2016-09-06 17:20 +0200 |
| Message-ID | <seqki-3Gd-13@gated-at.bofh.it> (permalink) |
| References | <sccOu-2m4-23@gated-at.bofh.it> <sdfAB-3qO-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sat 03-09-16 17:33:39, Eric Ren wrote: > Hi Geliang, > > On 08/31/2016 08:23 PM, Geliang Tang wrote: > >There are some repetitive code in jbd2_journal_init_dev() and > >jbd2_journal_init_inode(). So this patch extracts the common code into > >jbd2_journal_init() helper to simplify the code. And fix the coding > >style warnings reported by checkpatch.pl by the way. > journal_init_common() is already there for the same purpose, right? > Do we really need another helper? Agreed, just move the common code into journal_init_common(). Also the __getblk() in jbd2_journal_init_dev() should be getblk_unmovable() so that would be a good preparatory fix to remove the need of the gfp argument. Honza -- Jan Kara <jack@suse.com> SUSE Labs, CR
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] jbd2: add jbd2_journal_init() helper Geliang Tang <geliangtang@gmail.com> - 2016-08-31 14:30 +0200
Re: [PATCH] jbd2: add jbd2_journal_init() helper Eric Ren <zren@suse.com> - 2016-09-03 11:40 +0200
Re: [PATCH] jbd2: add jbd2_journal_init() helper Jan Kara <jack@suse.cz> - 2016-09-06 17:20 +0200
[PATCH] Re: [PATCH] jbd2: add jbd2_journal_init() helper Geliang Tang <geliangtang@gmail.com> - 2016-09-07 14:50 +0200
csiph-web