[PATCH] drm/atomic: mode_set encoders when routing changes

Path	csiph.com!1.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!news2.arglkargh.de!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Brian Starkey <brian.starkey@arm.com>
Newsgroups	linux.kernel
Subject	[PATCH] drm/atomic: mode_set encoders when routing changes
Date	Tue, 06 Sep 2016 17:20:01 +0200
Message-ID	<seqkh-3Gd-5@gated-at.bofh.it> (permalink)
X-Original-To	airlied@linux.ie
X-Mailer	git-send-email 1.7.9.5
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	30
Organization	linux.* mail to news gateway
X-Original-Cc	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Liviu.Dudau@arm.com
X-Original-Date	Tue, 6 Sep 2016 16:12:36 +0100
X-Original-Message-ID	<1473174756-14517-1-git-send-email-brian.starkey@arm.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1477496

Show key headers only | View raw

crtc_set_mode() only checks if the CRTC mode has changed when deciding
whether encoders require a mode_set. This is insufficient when the CRTC
mode isn't changed but a new encoder is added to it, leading to encoders
never getting mode_set.

Fix this by also checking that a connector's CRTC and encoder have not
changed before skipping its encoder's mode_set.

Signed-off-by: Brian Starkey <brian.starkey@arm.com>
---
 drivers/gpu/drm/drm_atomic_helper.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c
index 20be86d..206fba1 100644
--- a/drivers/gpu/drm/drm_atomic_helper.c
+++ b/drivers/gpu/drm/drm_atomic_helper.c
@@ -876,7 +876,9 @@ crtc_set_mode(struct drm_device *dev, struct drm_atomic_state *old_state)
 		mode = &new_crtc_state->mode;
 		adjusted_mode = &new_crtc_state->adjusted_mode;
 
-		if (!new_crtc_state->mode_changed)
+		if (!new_crtc_state->mode_changed &&
+		    connector->state->crtc == old_conn_state->crtc &&
+		    connector->state->best_encoder == old_conn_state->best_encoder)
 			continue;
 
 		DRM_DEBUG_ATOMIC("modeset on [ENCODER:%d:%s]\n",
-- 
1.7.9.5

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH] drm/atomic: mode_set encoders when routing changes Brian Starkey <brian.starkey@arm.com> - 2016-09-06 17:20 +0200

csiph-web