Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1477459

Re: [PATCH] ARM: mmp: replace NO_IRQ

Show all headers | View raw

On Tue, Sep 06, 2016 at 04:07:56PM +0200, Arnd Bergmann wrote:
> The mmp platform has its own definitions with the old NO_IRQ meaning,
> but compares against the global NO_IRQ macro that we should have
> removed long ago.
> 
> The specific usage in arch/arm/mach-mmp/devices.c is awkward, but
> fixing it properly would require a larger scale rewrite of the entire
> file, or even using devicetree for all machines. As I'm not able to
> do that any time soon, let's make the current behavior more explit
> instead and avoid the literal use of NO_IRQ.

So this probably continues to be a problem, but we hide it from the
NO_IRQ brigade.  I think it would be better to leave it as-is until
it can be fixed up correctly, rather than trying to hide it.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ARM: mmp: replace NO_IRQ Arnd Bergmann <arnd@arndb.de> - 2016-09-06 16:10 +0200
  Re: [PATCH] ARM: mmp: replace NO_IRQ Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-09-06 16:30 +0200
    Re: [PATCH] ARM: mmp: replace NO_IRQ Arnd Bergmann <arnd@arndb.de> - 2016-09-06 21:30 +0200
      Re: [PATCH] ARM: mmp: replace NO_IRQ Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-09-06 21:50 +0200
        Re: [PATCH] ARM: mmp: replace NO_IRQ Linus Torvalds <torvalds@linux-foundation.org> - 2016-09-06 22:10 +0200
          Re: [PATCH] ARM: mmp: replace NO_IRQ Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-09-06 23:30 +0200
            Re: [PATCH] ARM: mmp: replace NO_IRQ Arnd Bergmann <arnd@arndb.de> - 2016-09-08 22:20 +0200
        Re: [PATCH] ARM: mmp: replace NO_IRQ Arnd Bergmann <arnd@arndb.de> - 2016-09-06 22:20 +0200
          Re: [PATCH] ARM: mmp: replace NO_IRQ Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-09-06 22:50 +0200

csiph-web