Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1477475

Re: [PATCH v11 5/8] clocksource/drivers/arm_arch_timer: Simplify ACPI support code.

From Thomas Gleixner <tglx@linutronix.de>
Newsgroups linux.kernel
Subject Re: [PATCH v11 5/8] clocksource/drivers/arm_arch_timer: Simplify ACPI support code.
Date 2016-09-06 16:50 +0200
Message-ID <sepRg-3ha-35@gated-at.bofh.it> (permalink)
References <seoBP-2y1-3@gated-at.bofh.it> <seoBR-2y1-47@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Tue, 6 Sep 2016, fu.wei@linaro.org wrote:
> +	if (timer_count < 0)
> +		pr_err("Failed to get platform timer info, skipping.\n");

So this prints something about skipping. But then it continues as if
nothing went wrong. That's either wrong or confusing or both.

> -	arch_timer_init();
> -	return 0;
> +	return arch_timer_init();

Thanks,

	tglx

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v11 5/8] clocksource/drivers/arm_arch_timer: Simplify ACPI support code. fu.wei@linaro.org - 2016-09-06 15:30 +0200
  Re: [PATCH v11 5/8] clocksource/drivers/arm_arch_timer: Simplify  ACPI support code. Thomas Gleixner <tglx@linutronix.de> - 2016-09-06 16:50 +0200
    Re: [PATCH v11 5/8] clocksource/drivers/arm_arch_timer: Simplify ACPI  support code. Fu Wei <fu.wei@linaro.org> - 2016-09-07 11:30 +0200

csiph-web