Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1477363

Re: [PATCH] security/keys: make BIG_KEYS dependent on stdrng.

From David Howells <dhowells@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH] security/keys: make BIG_KEYS dependent on stdrng.
Date 2016-09-06 15:20 +0200
Message-ID <seos9-2uF-13@gated-at.bofh.it> (permalink)
References <seoiu-2rH-27@gated-at.bofh.it> <se1lT-3KI-1@gated-at.bofh.it> <seo8T-29v-21@gated-at.bofh.it> <seoiu-2rH-27@gated-at.bofh.it>
Organization Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903

Show all headers | View raw


Artem Savkov <asavkov@redhat.com> wrote:

> > > -	select CRYPTO
> > > +	depends on (CRYPTO_ANSI_CPRNG = y || CRYPTO_DRBG = y)
> > 
> > Should those be "==" not "="?
> 
> Accodring to Documentation/kbuild/kconfig-language.txt (line 173) it is
> "=" and I can only see "=" being used in existing Kconfigs.

Okay.  The other thing is that I have been given a conflicting patch (see
below).  Is your fix preferable?

David
---
commit 69ed34b303f87a1a53470dd37149ac1573d79da2
Author: Kirill Marinushkin <k.marinushkin@gmail.com>
Date: Mon, 8 Aug 2016 23:19:32 +0200

KEYS: fix big_key dependency

Signed-off-by: Kirill Marinushkin <k.marinushkin@gmail.com>
cc: David Howells <dhowells@redhat.com>
cc: Peter Hlavaty <zer0mem@yahoo.com>
cc: Greg KH <gregkh@linuxfoundation.org>
cc: stable@vger.kernel.org
---
 security/keys/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/security/keys/Kconfig b/security/keys/Kconfig
index f826e87..8213221 100644
--- a/security/keys/Kconfig
+++ b/security/keys/Kconfig
@@ -44,7 +44,7 @@ config BIG_KEYS
 	select CRYPTO
 	select CRYPTO_AES
 	select CRYPTO_ECB
-	select CRYPTO_RNG
+	select CRYPTO_ANSI_CPRNG
 	help
 	  This option provides support for holding large keys within the kernel
 	  (for example Kerberos ticket caches).  The data may be stored out to

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] security/keys: make BIG_KEYS dependent on stdrng. Artem Savkov <asavkov@redhat.com> - 2016-09-05 14:40 +0200
  Re: [PATCH] security/keys: make BIG_KEYS dependent on stdrng. David Howells <dhowells@redhat.com> - 2016-09-06 15:00 +0200
    Re: [PATCH] security/keys: make BIG_KEYS dependent on stdrng. Artem Savkov <asavkov@redhat.com> - 2016-09-06 15:10 +0200
      Re: [PATCH] security/keys: make BIG_KEYS dependent on stdrng. David Howells <dhowells@redhat.com> - 2016-09-06 15:20 +0200
        Re: [PATCH] security/keys: make BIG_KEYS dependent on stdrng. Artem Savkov <asavkov@redhat.com> - 2016-09-06 15:30 +0200
        Re: [PATCH] security/keys: make BIG_KEYS dependent on stdrng. Kirill Marinushkin <k.marinushkin@gmail.com> - 2016-09-06 18:40 +0200
          Re: [PATCH] security/keys: make BIG_KEYS dependent on stdrng. David Howells <dhowells@redhat.com> - 2016-09-06 20:20 +0200
    Re: [PATCH] security/keys: make BIG_KEYS dependent on stdrng. Stephan Mueller <smueller@chronox.de> - 2016-09-06 15:20 +0200

csiph-web